-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"exclude" field in .nycrc.json no longer works #612
Comments
nyc doesn't have an |
@coreyfarrell thanks, I did a typo and meant to say jaydenseric/graphql-upload@0f92002#diff-ef814fc9852f9384bea581fd0673977dL2 |
Yeah, tap started explicitly excluding all test files from coverage, since that's almost never what you want (and it led to some weird bad behavior in some cases). I've been chatting with @coreyfarrell about better ways to structure the tap/nyc integration. It's a bit of weird interface boundary right now, and I think there are a few small improvements we could make on either side to avoid issues like this. |
We ended up using |
Nyc no longer used in tap 18. Check it out with |
The
exclude
field in.nycrc.json
no longer works. I'm guessing a recenttap
release started adding some defaults, causing the config file field to be ignored.Ideally the defaults would augment, and not replace, user config.
The text was updated successfully, but these errors were encountered: