Skip to content

Commit

Permalink
core: move failSkip/failTodo detection to TestBase
Browse files Browse the repository at this point in the history
The TestPoint class should really be *strictly* a string generator,
having pass/fail change in that function muddies the waters.

Part of TestBase's (admittedly, overly large) job is to determine whether
a test point should be a pass or a failure, so that it can decide whether
to show diagnostics, capture a stack trace, and so on.
  • Loading branch information
isaacs committed Sep 22, 2023
1 parent 3376bf9 commit 81044bd
Show file tree
Hide file tree
Showing 16 changed files with 51 additions and 232 deletions.
2 changes: 1 addition & 1 deletion src/core/dist/commonjs/test-base.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 15 additions & 7 deletions src/core/dist/commonjs/test-base.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/core/dist/commonjs/test-base.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/core/dist/commonjs/test-point.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions src/core/dist/commonjs/test-point.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/core/dist/commonjs/test-point.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 81044bd

Please sign in to comment.