Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -J to tap to auto calculate the cores #342

Closed
gdams opened this issue Feb 1, 2017 · 1 comment
Closed

Add -J to tap to auto calculate the cores #342

gdams opened this issue Feb 1, 2017 · 1 comment

Comments

@gdams
Copy link

gdams commented Feb 1, 2017 •
edited

It would be really great if we could add a feature to tap where instead of using tap -j<n> we could use tap -J and it would fetch the number of cores from os.cpus().length. The issue with having to pass in the number of cores is that it makes it very hard to implement parallel tap into a package.json
@isaacs
Copy link
Member

isaacs commented Feb 1, 2017

This is a good idea. Patch welcome, should be entirely doable in bin/run.js.

gdams pushed a commit to gdams/node-tap that referenced this issue Feb 1, 2017
Add -J to automatically calculate cores
00b4c63 
This PR allows you to pass in -J which will automatically calculate
the number of cores using `os.cpus.length()`

Fixes: tapjs#342
@gdams gdams mentioned this issue Feb 1, 2017
Closed
@isaacs isaacs closed this as completed in f3f0a6b Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @gdams