tearDown behavior changed between tap@9 and tap@10

[iarna]

Given this code:

var test = require('tap').test

test('step1', function (t) {
  console.log('##############', 'step1 startup')
  t.tearDown(function () {
    console.log('##############', 'step1 teardown')
  })
  setImmediate(t.done)
})
test('step2', function (t) {
  console.log('##############', 'step2 startup')
  t.tearDown(function () {
    console.log('##############', 'step2 teardown')
  })
  setImmediate(t.done)
})

With tap@9 we get:

TAP version 13
# Subtest: step1
############## step1 startup
    1..0
ok 1 - step1 # time=3.156ms

############## step1 teardown
# Subtest: step2
############## step2 startup
    1..0
ok 2 - step2 # time=0.41ms

############## step2 teardown
1..2
# time=28.267ms

Note that step1 teardown runs before step2 startup.

By contrast, under tap@10 we get:

TAP version 13
############## step1 startup
# Subtest: step1
    1..0
ok 1 - step1 # time=6.531ms

############## step2 startup
############## step1 teardown
# Subtest: step2
    1..0
ok 2 - step2 # time=1.262ms

############## step2 teardown
1..2
# time=15.991ms

Note that step2 startup actually runs before step1 teardown now.

Practically, this was causing test failures in npm for test/tap/add-remote-git-submodule.js.

[isaacs]

Bona fide bug. Will address soon. Thanks for the report :)