Added source map support #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this will probably have to be rebased (or completely rewritten) to work on v10. I've pinged @jamestalmage to see about getting that stuff landed in stack-utils. This patch looks pretty straightforward, so I'll probably be able to forward port it myself, but I'll let you know if that hits any snags. Thanks! |
|
@isaacs - Fixed it up for you 👍 |
|
Thanks! Squashed the commits and landed on master. Care to review 3d89b54 and make sure that it looks right? Seems very straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as tapjs/stack-utils#22 is landed and the stack-utils version is bumped this will resolve #329