Add detection for .yaml and .yml #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the only potentially use-facing change is removal of `TAP_DEV_SHORTSTACK` environmental variable. Technically this has no effect on end users as it was always the default. `TAP_DEV_LONGSTACK` still exists and allows users to strip tapjs and other npm "internals" from stack traces.
PR-URL: tapjs#631 Credit: @coreyfarrell Close: tapjs#631 Reviewed-by: @isaacs EDIT(isaacs): cast settings.output to a boolean in the cleanForSnapshot function in settings tests.
One test in test/run/esm.js is skipped in node.js 12.2.0+ due to a compatibility issue with the `esm` module and `nyc`.
isaacs
reviewed
Feb 15, 2021
bin/run.js
Outdated
| } catch (er) { | ||
| } catch { | ||
| try { | ||
| if (fs.accessSync(path + '.yaml') === undefined) { |
There was a problem hiding this comment.
Why the access checks? Just read the file, if it throws, it's not there or you can't read it.
There was a problem hiding this comment.
Okay. I have updated the PR accordingly.
PR-URL: tapjs#668 Credit: @MylesBorins, @coreyfarrell Close: tapjs#668 Reviewed-by: @isaacs, @coreyfarrell
PR-URL: tapjs#622 Credit: @IlyaSemenov Reviewed-by: @isaacs
Also, add docs for t.notHas and t.notHasStrict
It doesn't support mjs natively, so some tests will always fail.
Closed
|
Landed on v15, will be in next release. Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #706.
I based my tests on
test/run/bad-rcfile.jsbecause I didn't see any other tests that cover parsing of rc files that I could learn from.I am not clear how to run the tests and generate an HTML coverage report so that I can see what branch(es) are not being covered. When I run
npm run unitI can see that some branch coverage is missing, but not what it is.