Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js min version to 10.x in CONTRIBUTING #752

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Update Node.js min version to 10.x in CONTRIBUTING #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Please consider signing [the neveragain.tech pledge](http://neveragain.tech/)
stuff that is likely to be accepted.
- Every patch should have a new test that fails without the patch and
passes with the patch.
- All tests should pass on Node 8 and above. If some tests have to be
skipped for very old Node versions that's fine, but the functionality
- All tests should pass on Node.js 10.x and above. If some tests have to
be skipped for very old Node versions that's fine, but the functionality
should still work as intended.
- Run `npm run snap` to re-generate the output tests whenever output is
changed. However, when you do this, make sure to check the change to
Expand Down