Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ff methods #15

Merged
merged 19 commits into from
Apr 23, 2018
Merged

Added ff methods #15

merged 19 commits into from
Apr 23, 2018

Conversation

Arpit-Patel
Copy link
Contributor

No description provided.

@Arpit-Patel Arpit-Patel requested a review from VicV April 5, 2018 20:11
@@ -140,6 +146,11 @@ - (void)sendPushEvent:(id)name withData:(NSDictionary *)userInfo
[Taplytics registerLocationAccess];
}

RCT_EXPORT_METHOD(featureFlagEnabled:(NSString *)key)
{
[Taplytics featureFlagEnabled:key];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still necessary?

@Arpit-Patel Arpit-Patel force-pushed the feature/#156311081-feature-flag-added branch from e57e416 to b5ea737 Compare April 23, 2018 19:03
@Arpit-Patel Arpit-Patel merged commit 8493874 into master Apr 23, 2018
@Arpit-Patel Arpit-Patel deleted the feature/#156311081-feature-flag-added branch April 23, 2018 20:01
hamzahayat added a commit that referenced this pull request Apr 23, 2021
* Refactored SDK to be more modular

* Removed TaplyticsProvider imports

* Removed unused and undocumented native methods

* Added _newSessionCallback native method and exported it as part of `setTaplyticsNewSessionListener` method

* Changed newSyncObject to take in NSDictionary

* Added getVariables and registerVaraiblesChangedListener methods and removed lodash and only added lodash.clonedeep

* Add library to gitignore and prettierignore

* Added extra line on ignore files

* Added push method types and cleaned up the push methods

* Removed old index files and added push types to index

* Added TaplyticsProvider

* Removed console.log and exported TaplyticsProvider from index.ts

* Updated TaplyticsProvider to fetch properties on App Start for android

* Export TaplyticsProvider

* Added useFeatureFlag hook (#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants