-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max-width to none for all images in jcrop-holder #22
Conversation
Fixes issues when combining Jcrop with responsive grids like Zurb Foundation.
Since this issue is direcly related to your CSS. The fix should be in your stylesheet. |
The fix is general though and not really specific to my stylesheet, its basically a reset which makes sure Jcrop works correctly. Frameworks like Zurb Foundation are getting quite popular and as it is everyone who wants to combine it with Jcrop will have to dig up this fix manually |
Just discovered this same issue affects Twitter Bootstrap 2.0. +1 for merge |
Yep it will affect most sites using a responsive design, including all Zurb Foundation and Twitter Bootstrap users |
If the author feels this is an unwanted addition, at least something should go into the README or wiki. It took quite a while to diagnose the problem. |
+1 for merge, it fixes the problem for Twitter Bootstrap 2.0.1 |
Though I do have some reservations about fixing whatever general CSS people might try to craft, I don't mind doing a few common resets since it's only a few extra bytes of CSS, and I do personally like Bootstrap a lot. I agree with @bmaland that it's general enough to warrant inclusion. I have committed this change to the CSS and will be pushing within the hour. I am going to close this pull request. Sorry for lagging so long in getting to it, thanks for all your patience. |
thank you bmalad, you helped me solve this issue I was strugling for days |
I know this issue is closed for 2 years but isn't there a fix which can be applied to jcrop itself so it can deal with |
Fixes issues when combining Jcrop with responsive grids like e.g. Zurb Foundation.
Took a while to debug this, but Zurb Foundation's grid.css sets max-width to 100% for all images which completely breaks Jcrop (see screenshot below). Simply setting max-width to none for all images within the jcrop-holder fixes the issue.