New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add bulk change option #52
Comments
Hey, thanks for the feedback. |
o_O do you have a collection of throw-away accounts? :] Greetings, guilty-snake Yes, I need to avoid "suspicious" behaviour by the app. Eg. code for an completely automatic update is there but will even trigger Windows built-in malware protection on the system were I actually build the software. |
Ahah, busted I see :( |
No, it's a not a problem when building but while running the code. |
I realized afterwards that my question was dumb, if the issue was arising only during building, then you could just disable your AV during this step (unlike an updated version with a bulk mode where everyone who would want to use it would need to disable their AV while using the app). In the meantime, maybe an intermediary solution would be to add the ability to change a plugin's default settings? Because I tried modifying the file: C:\Program Files (x86)\OpenVR-FSR-App\data\openvr_fsr\openvr_mod.cfg |
If you would like to implement this please feel free to create a fork and I'll see where I can help. To clear things up: 1. I do not want to potentially trigger AV from any software I release 2. I see no use in a bulk change of options: These plugins will worsen your image quality with no performance gain in 85% of use cases. They can however help in very special scenarios where a system is GPU limited with very high-res HMDs. So these need to be very finely tuned for the 2-3 apps where this might apply. Applying these plugins to a lot of apps simply does not make sense. If someone is just after sharpening filters: there are lot more configurable and performant options available e.g. VRToolkit I'll hope to get this clarification/explanation into the app at some point in the future. Currently my impression is user's send links to FSR/fixed FOV/OpenXR Toolkit and alike around as a generic one click approach to obtain better performance which simply isn't the case for any of those. |
Hey, I had a look at your code, and that's way beyond my skills (Classes, decorators and so on) I just started doing a bit of Python a few weeks ago, but very basic stuff, and my job is not being a developer. |
I guess both of us lack the numbers to prove our points here :) I kindly ask to continue discussion about performance and hardware in forums/discord. This is not to say you're wrong and I'm right, just the wrong place for a discussion we could have for weeks without proper numbers showing CPU -and- GPU frame times with and without these plugins enabled on a broad selection of apps. |
https://www.techpowerup.com/review/amd-fsr-fidelityfx-super-resolution-quality-performance-benchmark/9.html Those are not VR games, but AFAIK, there is no video game engine specifically developed to be used exclusively in VR games, so I see no reason why these results could not be extrapolated for VR (especially when only FSR with high res is taken into account, a case that yields bigger gains). So, I would really like to see your numbers that make you say: "These plugins will worsen your image quality with no performance gain in 85% of use cases." You can probably find a few games for which there would be no performance gain in 4K upscaled with FSR in Balanced mode, but definitely not 85%. |
Hello, I'm trying to build the app on Windows 11, but I ran into this error (not the first one, but was able to solve the previous ones): `(openvr_fsr_app-master-fkHXQenE) C:\Users\guilty-snake\Downloads\openvr_fsr_app-master>python.exe run.py
Any idea? P.S.: I'm not a dev, so please bear with me :p |
Hmm, I can create an environment without problems using: Your npm install command installs the plugin into your global npm modules. Maybe try to uninstall and then install the exact version stated in the lock files: and just in case anything else is missing: |
Hi, thanks for you reply. Where should I run the commands from, if that matters? I executed those 2 commands:
success Uninstalled packages. for both. Then, as you suggested, I ran:
But vue CLI is still complaining: And npm modules can be installed either globally or locally? |
Inside the directory where you cloned the git repo.
Does not matter as long as you are in the right dir.
That's what pipenv is for. Pip would use your system interpreter while pipenv creates a virtual environment for you.
There are plenty of suggestions you could try:
If you have only one node.js project it doesn't really matter but in general it will save you head aches if you place dependencies locally inside your project space. |
Hey, Thanks, eventually, it worked ! I thought I was gonna give up :p Edit: No happy when running the tests though :(
|
pipenv is just for python. pipenv shell may changed your PATH sys variable(inside the local shell) and you were finally able to install the deps because yarn could not resolve to system wide deps.
Yes, the app is only useful on Windows(plugins are platform specific dll's) so a Docker container has no use here.
Just run them a second time. Some files need to be created on first run. |
Hello, thank you for the answers. I ran the tests like 3 times in a row, but it is still throwing errors: `(openvr_fsr_app-master-fkHXQenE) C:\Users\guilty-snake\Downloads\openvr_fsr_app-master\tests>python -m pytest test_app\test_app_fn.py ....FF. [ 17%] ================================================================================================================= FAILURES ================================================================================================================= app_settings = <class 'app.app_settings.AppSettings'>, custom_dir_id = '#9386', custom_lib_path = WindowsPath('C:/Users/guilty-snake/Downloads/openvr_fsr_app-master/tests/data/input/custom_dir'), custom_app_id = '#9386_7532'
test_app\test_app_fn.py:66: s = None, cls = None, object_hook = None, parse_float = None, parse_int = None, parse_constant = None, object_pairs_hook = None, kw = {}
E TypeError: the JSON object must be str, bytes or bytearray, not NoneType C:\Program Files\Python310\lib\json_init_.py:339: TypeError CRITICAL root:utils.py:100 <class 'KeyError'>: 'Usr_8997' app_settings = <class 'app.app_settings.AppSettings'>, custom_dir_id = '#9386', custom_lib_path = WindowsPath('C:/Users/guilty-snake/Downloads/openvr_fsr_app-master/tests/data/input/custom_dir'), custom_app_id = '#9386_7532'
test_app\test_app_fn.py:66: s = None, cls = None, object_hook = None, parse_float = None, parse_int = None, parse_constant = None, object_pairs_hook = None, kw = {}
E TypeError: the JSON object must be str, bytes or bytearray, not NoneType C:\Program Files\Python310\lib\json_init_.py:339: TypeError CRITICAL root:utils.py:100 <class 'KeyError'>: 'Usr_8997' ..\app\valve\steam.py:33 -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html (openvr_fsr_app-master-fkHXQenE) C:\Users\guilty-snake\Downloads\openvr_fsr_app-master\tests> Is it because it can't get the proper path of my steam library folder for some reason, hence why the returned object is of NoneType? |
Hello,
It's more a new feature request than a bug report.
Would it be possible to add an option to be able to either bulk apply the same settings for all games in one's library or solely to manually selected games?
I think the idea is simliar to the one mentionned in the second part of issue #51.
The text was updated successfully, but these errors were encountered: