Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support glob in bower main property #124

Closed
wants to merge 2 commits into from

Conversation

gernsdorfer
Copy link

Support globing for files in main property of bower.json.
With that change we want eliminate dist directory, so no build is necessary and no dist is under version control. This avoids unnecessary conflicts and tags which contain the wrong version (if build forgotten).

See also bower/bower#935 and bower/spec#30

@ruyadorno
Copy link
Contributor

I would rather wait for the official spec update from the @bower team before landing this on wiredep.

@stephenplusplus
Copy link
Member

I actually don't mind supporting this. The more time that goes on, the more it seems the Bower community isn't waiting on decisions, and instead using what makes sense.

});
});

return files;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the code style - 2 space indentation.

@stephenplusplus
Copy link
Member

I made some changes -- can you check if this works: c70d1f3

if it does, I'll merge that branch in instead of this PR.

@gernsdorfer
Copy link
Author

work's fine.:thumbsup:

@stephenplusplus
Copy link
Member

Cool, merged that in. 👍 Thanks for this!

@CWSpear
Copy link
Contributor

CWSpear commented Nov 7, 2014

I actually don't mind supporting this. The more time that goes on, the more it seems the Bower community isn't waiting on decisions, and instead using what makes sense.

Poor Bower :-( But I don't disagree. That's the theme of my first PR (overrides). And I think wiredep is gaining enough traction that people can tell other plugins, "but wiredep does it!" and maybe implement it.

But with the added wiredep().js syntax, I've changed my approach and don't even need those other plugins that use the overrides syntax =)

@stephenplusplus
Copy link
Member

"but wiredep does it!"

👯 💃 👍 🎉 🎈 🎂

@ruyadorno
Copy link
Contributor

Great! TBH I do agree that wiredep should have a more active role, taking stances like this, specially in the stalled state of bower lately. I just didn't expected you guys would think the same 😊

@zarno
Copy link

zarno commented Nov 17, 2014

Nice work! Thanks heaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants