-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support glob in bower main property #124
Conversation
I would rather wait for the official spec update from the @bower team before landing this on wiredep. |
I actually don't mind supporting this. The more time that goes on, the more it seems the Bower community isn't waiting on decisions, and instead using what makes sense. |
}); | ||
}); | ||
|
||
return files; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the code style - 2 space indentation.
I made some changes -- can you check if this works: c70d1f3 if it does, I'll merge that branch in instead of this PR. |
work's fine.:thumbsup: |
Cool, merged that in. 👍 Thanks for this! |
Poor Bower :-( But I don't disagree. That's the theme of my first PR ( But with the added |
👯 💃 👍 🎉 🎈 🎂 |
Great! TBH I do agree that wiredep should have a more active role, taking stances like this, specially in the stalled state of bower lately. I just didn't expected you guys would think the same 😊 |
Nice work! Thanks heaps. |
Support globing for files in main property of bower.json.
With that change we want eliminate dist directory, so no build is necessary and no dist is under version control. This avoids unnecessary conflicts and tags which contain the wrong version (if build forgotten).
See also bower/bower#935 and bower/spec#30