-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki edits disappear after clicking preview, textile or save #83
Comments
Note to self: |
Hello. We have the same problem here.
So it seems to come from this code:
|
Hi @nanego Thank you for your information. Could you please tell me your wiki link code which causes an error? |
I assume that the dockerfile is for me? The content of the script looks Linux centric, not sure it will work on my windows installation. After reading the comment from @nanego, I realized I should look at the browser console. I installed 0.15.1, then looked to see if the issue was fixed. It is not, the attached file contains the error information from the browser console. |
No, it is just for me.
0.15.1 has resolved not this issue but #84. Thank you for your console log. |
If there is anything I can do to help let me know. I’m not sure I can do much, I have very little knowledge about Ruby or Java. |
Hi @randylang Could you please replace redmine_wysiwyg_editor.js with attached one and tell me the href values on console.log? |
Hi @taqueci
|
Hi @nanego Thank you for your information.
|
Hi @nanego and @randylang Could you please try branch issue/83? |
I will try it as soon as I have a chance. Thank you.
On Tue, Apr 28, 2020 at 8:57 AM taqueci ***@***.***> wrote:
Hi @nanego <https://github.com/nanego> and @randylang
<https://github.com/randylang>
Could you please try branch issue/83
<https://github.com/taqueci/redmine_wysiwyg_editor/tree/issue/83>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKH3IIEPBZ3QRFE3BI5ABPDRO3HEZANCNFSM4LTYBUZA>
.
--
Randy Lang
Electrical Engineer
randy.lang@ieee.org
http://www.linkedin.com/in/randylang
|
I don't think it worked. I snagged the complaints from the Chrome console. wysiwyg issue 83 chrome log tinymce verbose-1588092846055.log |
Thank you for this patch @taqueci. I tested it. Unfortunately, it does not fix the issue in my case. I still get the same errors in my browser. |
Actually, I just retried in wikis, and the error seems to be gone. |
I spent some time with the console, I caused the issue by adding some text to a page, then switching from visual editor to preview. I set a break at line 895. When the errors occur, href at line 897 is: When it works, I don't know if its relevant but when it fails, When it works, node = a.wiki-page { . . . } My hunch is that the regular expression needs to be reworked to function when href includes the query. The structure that was added to the page in question is like the following (shown in textile for clarity) Software Processes is an existing page. The New Text was the added content.
h2. Some header |
Hi @randylang Thank you for your information. Could you please try branch issue/83a? |
I believe you have fixed it. Thank you for the help and the excellent plugin. |
The commit has been merged to the mater branch. |
I'm pleased that it works. I’ve been using it all day. I wish I had realized there was a debugger built into chrome sooner, I wouldn’t have wasted your time with all those log files. |
Hi @nanego
I don't know the latest version solves your problem or not. |
There are some instances when edits made in the Visual Editor disappear after saving or switching to one of the other views.
It does not happen when editing a new page.
I have tested several situations on one page to verify statement made in this issue:
The text was updated successfully, but these errors were encountered: