Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button not disabled on browser startup #1

Closed
crustyturd opened this issue May 10, 2021 · 5 comments
Closed

Button not disabled on browser startup #1

crustyturd opened this issue May 10, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@crustyturd
Copy link

Clearing unclosed tabs disables toolbar button. However, on browser restart, button is no longer disabled, even though there are no unclosed tabs.

Palemoon 29.2.0

@crustyturd
Copy link
Author

I meant to say "even though there are no 'closed' tabs."

@crustyturd
Copy link
Author

Should the button not also be in disabled state after all closed tabs have been reopened?

@tarakbumba
Copy link
Owner

No. It's not like that. Even original add-on, Undo Closed Tabs Button add-on, behaves same as your description. It's not a buggy behaviour, clicking on button doesn't cause an issue. Also you can see that in translations, there's a label set for this behaviour: "No closed tabs to undo".

@tarakbumba tarakbumba added the bug Something isn't working label May 16, 2021
@tarakbumba
Copy link
Owner

OK. I think I've found the culprit. There was a function which is removed due to another issue. I re-added it and modified for this fork. It should be ok. Would you mind to test version 1.3beta1 and report back?

@tarakbumba
Copy link
Owner

tarakbumba commented May 19, 2021

I released a new 1.3beta3 release today. This release should also fix a left-over issue from original code and re-introduced by previous beta that extension tries to open non-existent welcoming web page upon extension install/upgrade. Please test this 1.3beta3 and report back?

@tarakbumba tarakbumba added the Fixed but needs testing A fix is applied to code but needs testing label May 19, 2021
@tarakbumba tarakbumba removed the Fixed but needs testing A fix is applied to code but needs testing label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants