Update 100-setup-error-pages.sh

[xpliz]

Description

Random template generator, also picked up nginx-error-pages template, which we don't want. Proposing small patch to exclude from allowed_templates

[tarampampam]

👍 Great thanks for your contribution!

[xpliz]

Did I mess up this patch? Can't find it in code.

[tarampampam]

@xpliz You closed this PR before I merge it. Also, can you say how to reproduce the fixed error?

[xpliz]

Well I just exec-ed into the container and checked what your piece of code returns and I saw find /opt/html/* -maxdepth 1 -type d also listed nginx-error-pages template/directory beside all available templates. I noticed that sometimes I got reply when getting an error with standard nginx message which bothered me and I looked into the code why.

errorpages    | /docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
errorpages    | /docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
errorpages    | /docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
errorpages    | 10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
errorpages    | 10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
errorpages    | /docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
errorpages    | /docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
errorpages    | /docker-entrypoint.sh: Launching /docker-entrypoint.d/100-setup-error-pages.sh
errorpages    | /docker-entrypoint.d/100-setup-error-pages.sh: Use 'nginx-error-pages' as randomly selected template
errorpages    | /docker-entrypoint.d/100-setup-error-pages.sh: Set pages for template 'nginx-error-pages' as default (make accessible in root directory)
errorpages    | /docker-entrypoint.sh: Configuration complete; ready for start up

This error message from container logs bothered me and I looked into it.

Will reopen the patch. Sorry I'm not that handy with git. I thought I pushed 2 patches by mistake ...

Also that feature request with random pages was more of a can I get a random template on every request not just container restart :) But of course anything is better than nothing :) Once I looked more into the code how things are spawn I saw template is generated on start and your random page solution was a nice workaround/hack :) Not sure why standard nginx-error-pages is there tho to be honest.

[tarampampam]

Thanks for the detailed response! I have made other changes, could you approve them?

[xpliz]

This github baffles me :)

[xpliz]

I can't seem to find approve or merge lol ¯_(ツ)_/¯

[tarampampam]

Released in https://github.com/tarampampam/error-pages/releases/tag/v1.7.1