Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Better CLI #163

Merged
merged 5 commits into from Jan 29, 2023
Merged

chore: Better CLI #163

merged 5 commits into from Jan 29, 2023

Conversation

tarampampam
Copy link
Owner

@tarampampam tarampampam commented Jan 23, 2023

Description

Changed

  • version subcommand replaced by --version flag
  • --config-file flag is not global anymore (use error-pages (serve|build) --config-file ... instead of error-pages --config-file ... (serve|build) ...)
  • Flags --verbose, --debug and --log-json are deprecated, use --log-level and --log-format instead

Related issue: #162

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests are required for my changes)
  • I have made changes in the CHANGELOG.md file

@tarampampam tarampampam self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #163 (8404e01) into master (6a6809b) will increase coverage by 6.78%.
The diff coverage is 61.31%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   41.81%   48.59%   +6.78%     
==========================================
  Files          32       32              
  Lines        1325     1247      -78     
==========================================
+ Hits          554      606      +52     
+ Misses        737      603     -134     
- Partials       34       38       +4     
Impacted Files Coverage Δ
internal/cli/serve/command.go 0.00% <0.00%> (ø)
internal/env/env.go 100.00% <ø> (ø)
cmd/error-pages/main.go 52.94% <60.00%> (-47.06%) ⬇️
internal/logger/format.go 63.63% <63.63%> (ø)
internal/cli/app.go 65.11% <65.11%> (ø)
internal/cli/build/command.go 20.87% <72.72%> (+20.87%) ⬆️
internal/logger/logger.go 90.24% <84.61%> (-9.76%) ⬇️
internal/cli/healthcheck/command.go 100.00% <100.00%> (+10.00%) ⬆️
internal/logger/level.go 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tarampampam tarampampam marked this pull request as ready for review January 29, 2023 10:54
@tarampampam tarampampam merged commit 252618a into master Jan 29, 2023
@tarampampam tarampampam deleted the new-cli branch January 29, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant