Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx Healthcheck endpoint + Dockerfile healthcheck #23

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

tarampampam
Copy link
Owner

Description

Previous PR updates

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

modem7 and others added 2 commits September 4, 2021 22:27
* added healthcheck endpoint and updated dockerfile to utilise

* Update CHANGELOG.md
@tarampampam tarampampam self-assigned this Sep 4, 2021
@tarampampam tarampampam changed the title Add healthcheck Nginx Healthcheck endpoint + Dockerfile healthcheck Sep 4, 2021
@tarampampam
Copy link
Owner Author

@modem7 could you please review these changes?

Copy link
Contributor

@modem7 modem7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the healthcheck period is a bit too short, 10-20 seconds is definitely sufficient for this type of container. It may cause false positives if its too quick.

@tarampampam tarampampam merged commit ce98410 into master Sep 6, 2021
@tarampampam tarampampam deleted the add-healthcheck branch September 6, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants