Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Too big request header" #244

Merged
merged 5 commits into from Nov 20, 2023
Merged

Conversation

alphanoob1337
Copy link
Contributor

Description

New environment variable READ_BUFFER_SIZE to fix HTTP error 431 "Too big request header" if used in a setup where a lot of Cookies could be present. Solves issue #238.

Please feel free to modify. So far I only tested this as docker image and not when deployed via CLI or with nginx.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2c8ba9c) 48.13% compared to head (c40695f) 47.90%.

Files Patch % Lines
internal/cli/serve/command.go 0.00% 9 Missing ⚠️
internal/http/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   48.13%   47.90%   -0.23%     
==========================================
  Files          32       32              
  Lines        1257     1263       +6     
==========================================
  Hits          605      605              
- Misses        614      620       +6     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarampampam tarampampam linked an issue Nov 20, 2023 that may be closed by this pull request
2 tasks
@tarampampam tarampampam merged commit 8e7570e into tarampampam:master Nov 20, 2023
15 checks passed
@tarampampam
Copy link
Owner

👍 Thank you so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Too big request header"
2 participants