Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Host" and "X-Forwarded-For" header options #61

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

flo-mic
Copy link
Contributor

@flo-mic flo-mic commented Jan 30, 2022

Description

This PR adds two additional headers for "Host" and "X-Forwarded-For". These headers can support on issues if you run behind a reverse proxy or if your ingress object is serving more than one url.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam
Copy link
Owner

You've done a tremendous job! Thank you!

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #61 (5f48587) into master (da2dc5c) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   38.84%   38.76%   -0.08%     
==========================================
  Files          31       31              
  Lines        1022     1024       +2     
==========================================
  Hits          397      397              
- Misses        594      596       +2     
  Partials       31       31              
Impacted Files Coverage Δ
internal/http/core/errorpage.go 0.00% <0.00%> (ø)
internal/tpl/properties.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2dc5c...5f48587. Read the comment docs.

@tarampampam tarampampam merged commit 42523ae into tarampampam:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants