-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error pages now translated in 🇫🇷 #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 42.90% 42.59% -0.31%
==========================================
Files 32 32
Lines 1296 1296
==========================================
- Hits 556 552 -4
- Misses 705 710 +5
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've done a tremendous job! Thank you!
@jvin042 v2.12.0 released! Please, check on your side after a few minutes (when the CI process is completed) |
@tarampampam idiot question, how do you put the language ? I did not find. I'm use docker-compose and traefik. The language detection does not work. I'm test Ghost et Connection template. |
@jvin042 this is a normal question :) The details are described here: Line 5 in 873944f
Also, each template loads the error-pages/templates/matrix.html Lines 265 to 272 in 873944f
So, if your browser locale Opened question is a cache lifetime on the jsdelivr side (I have found this explanation about the caching strategy) - I am currently looking for ways to clear the cache manually. |
https://cdn.jsdelivr.net/gh/tarampampam/error-pages@2/l10n/l10n.min.js at this moment contains outdated content (without the |
Automatic cache refreshing can takes about 12 hours. So, we can only have one option for now - wait for tomorrow ;) |
I have found the solution. Please, purge the cache in your browser and try again. Curl example for a checking: $ curl -s https://cdn.jsdelivr.net/gh/tarampampam/error-pages@2/l10n/l10n.min.js | head -c 499
/**
* Minified by jsDelivr using Terser v5.10.0.
* Original file: /gh/tarampampam/error-pages@2.12.0/l10n/l10n.js
*
* Do NOT use SRI with dynamically generated files! More information: https://www.jsdelivr.com/using-sri-with-dynamic-files
*/
Object.defineProperty(window,"l10n",{value:new function(){const e={Error:{fr:"Erreur",ru:"Ошибка",uk:"Помилка"},"Good luck":{fr:"Bonne chance",ru:"Удачи",uk:"Успіхів"},"UH OH":{fr:"Oups",ru:"Ох",uk:"Ох"},"Request details":{ |
@tarampampam I confirm that it works ! 😉 |
Description
Changed
Checklist
CHANGELOG.md
file