-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying confusing instance names #763
Comments
GRISHNOV
added a commit
that referenced
this issue
Apr 19, 2023
GRISHNOV
added a commit
that referenced
this issue
Apr 19, 2023
GRISHNOV
added a commit
that referenced
this issue
Apr 19, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 19, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 19, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 20, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 20, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 20, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 20, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 21, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 21, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 24, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 24, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
GRISHNOV
added a commit
that referenced
this issue
Apr 24, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
DifferentialOrange
pushed a commit
that referenced
this issue
Apr 24, 2023
Added instance name support for cases: * Application name as instance name * Instance name with dots Closes #763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1. Application name as instance name
Now we don't support instance names which coincide with application names:
2. Instance name with dots
The reason is this code in
GetInstancesFromArgs
method:cartridge-cli/cli/common/utils.go
Lines 385 to 387 in 80f0f63
We also do not support instance names with dots:
The reason is this code in
GetInstancesFromArgs
method:cartridge-cli/cli/common/utils.go
Lines 389 to 393 in 80f0f63
3. Specifying an instance name multiple times
GetInstancesFromArgs
also doesn't allow to specify an instance multiple times:cartridge-cli/cli/common/utils.go
Lines 400 to 402 in 80f0f63
Proposed solution
The reason of the issues 1 and 2 is the desire to help a user if they specified
application_name
orapplication_name.instance_name
instead ofinstance_name
. It results in inability to use some instance names in some commands which are (likely) supported by any other command. We need toTo preserve existing helpful error messages in case user really specified
application_name
orapplication_name.instance_name
instead ofinstance_name
(which is rather often), we'll need to rework our approach. If user had provided an invalid info, the command should fail. And if the command had failed,application_name
orapplication_name.instance_name
instead ofinstance_name
and, if they are, add this info to error message.Regarding issue 3, we may simply
but, since there are no such request from customers yet, we may ignore this one for now.
Based on https://jira.vk.team/browse/TNT-765
The text was updated successfully, but these errors were encountered: