tests: make integration testing faster #726
Merged
+102
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better0fdead
force-pushed
the
better0fdead/gh-609-tests
branch
4 times, most recently
from
982805a
to
acf5f8b
Compare
better0fdead
changed the title
LeonidVas
requested changes
Jul 13, 2022
|
Am I correct in assuming that further ticket work is planned or more ideas to accelerate testing? |
Separated integration tests from linter, unit, e2e and examples checks, because integration tests run longer then all other. Result: 15% faster testing. Part of #690
better0fdead
force-pushed
the
better0fdead/gh-609-tests
branch
5 times, most recently
from
58ac602
to
f53d0c9
Compare
LeonidVas
reviewed
Jul 14, 2022
magefile.go
Outdated
| @@ -161,9 +161,19 @@ func Unit() error { | |||
| // Run integration tests | |||
| func Integration() error { | |||
| mg.Deps(GenerateGoCode) | |||
|
|
|||
| build_projects_path := os.TempDir() + "/cartridge_cli_test_temp" | |||
| err := os.Mkdir(build_projects_path, 0777) | |||
There was a problem hiding this comment.
0777 - looks like overkill (write description in comments).
How about this question? |
better0fdead
force-pushed
the
better0fdead/gh-609-tests
branch
2 times, most recently
from
a29d950
to
750a49b
Compare
Added pre-building of project_with_cartridge and default_project before integration tests. Result: ~25-50% faster testing. Closes #390
better0fdead
force-pushed
the
better0fdead/gh-609-tests
branch
from
750a49b
to
714d564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated integration tests from linter, unit, e2e and examples checks.
Result: ~15% faster testing.
Added pre-building of slow projects.
Total result: ~40-65% faster.
Closes #690