Save previous member state into state_prev payload and fix member_is_healthy #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a Changelog note. |
|
And testing would be great. |
eugenepaniot
force-pushed
the
fix-member_is_healthy-prev_state
branch
from
5662f4d
to
30b27ed
Compare
yngvar-antonsson
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes situation when router sends requests to not fully (first start) RolesConfigured node. When node just started it had not configured roles (defined procedures) yet.
state_prevpayload;member_is_healthy) if previous state wereRolesConfiguredorConfiguringRoles. According to https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/#configuringroles transition. NotBoxConfigured -> ConfiguringRolesI didn't forget about
Close #???