error: remove failing code from microb integration #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtikhon
approved these changes
Dec 8, 2020
|
Patch LGTM. |
Totktonada
reviewed
Dec 14, 2020
Totktonada
approved these changes
Dec 14, 2020
In commit 51836e1 the code responsible for microb integration was removed, but not completely. Those remainings caused benchmark to exit with non-zero exit code if strict mode is on, which is true by default on any Debug build of Tarantool
.luacheckrc file was added with such a configuration that would detect the error fixed in previous commit. Some codestyle fixes were also applied as luacheck was complaining about them
koshoi
force-pushed
the
local_launches
branch
from
c4b4d0a
to
e897f40
Compare
|
I looked again at the code (quite briefly) and I have no any objections anymore. Didn't test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 51836e1 the code responsible
for microb integration was removed, but not completely. This remainings
caused benchmark to exit with non-zero exit code, which is not good for
automation. The other unused code was also removed. I also added
.luacheckrc config that could have spotted the error before.