Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix grants for tarantool 3 config cluster #417

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Jan 23, 2024

Fix vshard user grants setup for Tarantool 3.x through async bootstrap. See commits for more info.

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Closes #412
Part of #415

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch 7 times, most recently from ded906f to c846891 Compare January 24, 2024 07:46
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch 2 times, most recently from e308c71 to 70f41e3 Compare March 25, 2024 14:03
@DifferentialOrange DifferentialOrange changed the base branch from master to DifferentialOrange/gh-412-test-stabilization March 25, 2024 14:03
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch 3 times, most recently from f24dedb to 260e9bd Compare March 25, 2024 14:33
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-test-stabilization branch 3 times, most recently from f4238c2 to 9edeb74 Compare March 25, 2024 15:27
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch from 260e9bd to 359692c Compare March 25, 2024 15:58
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-test-stabilization branch from 9edeb74 to 3a6e1e2 Compare March 26, 2024 07:05
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch 5 times, most recently from e2b8486 to b21560e Compare March 26, 2024 13:09
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-test-stabilization branch from 55bd35d to b58f9b4 Compare March 27, 2024 13:19
Base automatically changed from DifferentialOrange/gh-412-test-stabilization to master March 27, 2024 13:21
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch from b21560e to cfbc6b3 Compare March 27, 2024 13:22
@DifferentialOrange DifferentialOrange changed the title Fix grants for Tarantool 3.0 config cluster storage: fix grants for Tarantool 3.0 config cluster Mar 27, 2024
This is the preliminary refactoring before solving the original issue.

Part of #412
Part of #415
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch from cfbc6b3 to 195881f Compare March 27, 2024 13:23
@DifferentialOrange DifferentialOrange marked this pull request as ready for review March 27, 2024 13:23
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch from 195881f to 3a7328b Compare March 29, 2024 14:29
@DifferentialOrange DifferentialOrange changed the title storage: fix grants for Tarantool 3.0 config cluster storage: fix grants for tarantool 3 config cluster Mar 29, 2024
Copy link
Contributor

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thx for patch

crud/storage.lua Show resolved Hide resolved
test/helper.lua Outdated Show resolved Hide resolved
crud/storage_info.lua Outdated Show resolved Hide resolved
crud/storage_info.lua Outdated Show resolved Hide resolved
Support asynchronous bootstrap for crud storages. The main motivation is
compatibility with Tarantool 3 instances, which start in read-only mode.

We do not support async bootstrap for crud routers since they do
not change `box`, thus may start on read-only instances without any
issues.

Part of #412
Part of #415
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-412-3.0-grants branch from ce65f86 to 14864f2 Compare April 1, 2024 16:18
@DifferentialOrange DifferentialOrange merged commit d03ede5 into master Apr 2, 2024
24 checks passed
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-412-3.0-grants branch April 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

box.info.ro can be true in init_storage() on all instances in replicaset
3 participants