-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text formatting and code examples according to Lua style guide #2249
Conversation
ac3a217
to
364cd01
Compare
bc0dba3
to
7b9b9f2
Compare
the main key_def_object, then all the fields of other_key_def_object which | ||
are not in the main key_def_object. | ||
Combine the main ``key_def_object`` with ``other_key_def_object``. | ||
The return value is a new ``key_def_object`` containing all the fields of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Totktonada
The names of the new and old objects are the same now, so it's a little confusing. The function returns a totally new object, not the altered old one—is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reply from @ Totktonada:
Да, :merge() возвращает новый объект.
@@ -191,7 +192,7 @@ to extract or compare the index key values. | |||
|
|||
.. code-block:: none | |||
|
|||
-- This will return a key definition with fieldno=3 and fieldno=1. | |||
-- This will return a key definition with fieldno = 3 and fieldno = 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Totktonada
"возвращает определение ключа по полям fieldno = 3 и fieldno = 1"? "для полей"? "содержащее поля"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation from @ Totktonada:
Давай я в целом про таплы, ключи и определения ключей напишу — должно стать понятней.
Тапл — это массив, строка в спейсе (можно сказать, в таблице, но таплы могут различаться по длине). Возьмем для примера [1, 'foo', 'bar'].
Определение ключа (key definition, key def) — это информация в духе «третье и первое поля тапла» (плюс еще типы в этих полях и еще разные детали). Порядок имеет значение.
Ключ или значение ключа — это в данном случае, собственно, массив из значения третьего и первого поля. Для тапла [1, 'foo', 'bar'] это будет ['bar', 1].
There must be at least one part and it | ||
must have at least fieldno and type. | ||
must have at least ``fieldno`` and ``type``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Totktonada
Must all parts have the fieldno
and type
attributes? Or can there be only one part with those attributes, while the other parts don't have those attributes? It is not quite clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All parts must have fieldno
or field
attribute (see #962). All parts must have type
attribute. Other attributes are optional. The parts
array should have at least one item.
Lines 11–12: What does "index key values" mean here? How are index and key related in this context? |
Say, we have a space (named 'users'):
With primary index by the 'id' field and secondary index by 'email' and 'name' fields. A get request by the primary index could be So index is usually constructed on a subset of tuple's fields and phrases like 'index key' mean a key that is suitable to perfrom a request using this index. |
Resolve #2236