Document the watchers and built-in events #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuniq
force-pushed
the
gh-2551-pub-sub-system
branch
from
1a0a8d9
to
4a87eca
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
locker
reviewed
Jun 28, 2022
| Each subscription is defined by the certain key. | ||
| The main feature of the subscriptions is a one-time action. | ||
| It means that if the server generates too many events and a client is too slow, | ||
| the server will not allocate additional memory. |
There was a problem hiding this comment.
I don't understand what this means. Maybe, refer to the section describing the watcher protocol in IPROTO, where we would describe how it's implemented and what exactly prevents the server from "allocating additional memory" if clients don't process events in time?
There was a problem hiding this comment.
Removed the sentence about "allocating additional memory". I'll return to this comment in #2408
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
locker
reviewed
Jul 4, 2022
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
xuniq
changed the title
unera
reviewed
Jul 25, 2022
xuniq
force-pushed
the
gh-2551-pub-sub-system
branch
from
e727318
to
51251d6
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
* check file path * update text * add glossary * fix links
* Renamed pub/sub section to System events, removed paragraph about pub/sub, moved the event definition to Event watchers section * Removed code-block with empty table for the event values * Fixed some refs and links
xuniq
force-pushed
the
gh-2551-pub-sub-system
branch
from
4758194
to
b357275
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
patiencedaur
reviewed
Aug 5, 2022
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
patiencedaur
reviewed
Aug 5, 2022
patiencedaur
reviewed
Aug 5, 2022
patiencedaur
reviewed
Aug 5, 2022
patiencedaur
reviewed
Aug 5, 2022
github-actions
bot
temporarily deployed
to
branch-gh-2551-pub-sub-system
p7nov
pushed a commit
that referenced
this pull request
Aug 11, 2022
Fixes #2551 Fixes #2409 Fixes #2407 * Add new functions to module box * Update watch and broadcast methods * Add System events section * Add glossary * Proofread text and add links Written by Kseniia Antonova Reviewed by Vladimir Davydov and Dmitry Oboukhov Proofread by Patience Daur Co-authored-by: Kseniia Antonova <xuniq.is.here@gmail.com> Co-authored-by: Patience Daur <patiencedaur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2551
Fixes #2409
Fixes #2407
Deploy: