Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Obsolete) 3.0 config #3773

Closed
wants to merge 4 commits into from
Closed

(Obsolete) 3.0 config #3773

wants to merge 4 commits into from

Conversation

@andreyaksenov andreyaksenov linked an issue Oct 17, 2023 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 17, 2023 10:16 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 17, 2023 10:41 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 17, 2023 14:03 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 18, 2023 11:46 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 18, 2023 12:47 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 18, 2023 14:13 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 18, 2023 14:42 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 18, 2023 18:40 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 10:27 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 11:50 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 12:03 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 12:32 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 14:00 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 19, 2023 14:51 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 20, 2023 07:41 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 30, 2023 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to branch-3.0-config October 30, 2023 15:31 Destroyed
Comment on lines +117 to +120
Since ``box.cfg`` may contain many configuration parameters and since some of the
parameters (such as directory addresses) are semi-permanent, it's best to keep
``box.cfg`` in a Lua file. Typically this Lua file is the initialization file
which is specified on the Tarantool command line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's best to keep box.cfg in a Lua file

It's simplest, but why the best? Cartridge, for example, allow to store box.cfg parameters in the cluster wide config.

And it is unclear how it is related to non-dynamic options.

Comment on lines +326 to +341
Starting a Tarantool instance
-----------------------------

Below is the syntax for starting a Tarantool instance configured in a Lua initialization script:

.. code-block:: console

$ tarantool LUA_INITIALIZATION_FILE [OPTION ...]

The ``tarantool`` command also provides a set of :ref:`options <configuration_command_options>` that might be helpful for development purposes.

The command below starts a Tarantool instance configured in the ``script.lua`` file:

.. code-block:: console

$ tarantool script.lua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we place it at beginning?

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes that are present is this PR don't contract with my understanding of the topic. I've left some nits around particular details here. Feels free to proceed with them in any way you'll find convenient.

@andreyaksenov andreyaksenov changed the title 3.0 config (Obsolete) 3.0 config Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants