tupleconv: initial logic #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
3 times, most recently
from
5136736 to
d914e0e
Compare
|
Can you please add some usage examples to the description of this PR? |
Allowed comments are |
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
2 times, most recently
from
eee12c2 to
6c6b25a
Compare
Sure, added. |
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
3 times, most recently
from
53c4951 to
d2105f6
Compare
|
Pls, add description and examples to readme. |
psergee
reviewed
Jul 28, 2023
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
from
ff50cbc to
d15c01a
Compare
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
from
5c1090d to
9056f9e
Compare
oleg-jukovec
reviewed
Aug 5, 2023
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
15 times, most recently
from
a32e548 to
66d1450
Compare
oleg-jukovec
reviewed
Aug 7, 2023
example_test.go
Outdated
Comment on lines
180
to
187
| if err != nil { | ||
| fmt.Println(err) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
It clean ups data folders etc.
Suggested change
| if err != nil { | |
| fmt.Println(err) | |
| return nil | |
| } | |
| if err != nil { | |
| test_helpers.StopTarantoolWithCleanup(inst) | |
| fmt.Println(err) | |
| return nil | |
| } |
oleg-jukovec
reviewed
Aug 7, 2023
example_test.go
Outdated
| const workDir = "work_dir" | ||
| const server = "127.0.0.1:3014" | ||
|
|
||
| func upTarantool() func() { |
There was a problem hiding this comment.
Suggested change
| func upTarantool() func() { | |
| func upTarantool() (func(), err) { |
It is more usual way. Up to you.
oleg-jukovec
approved these changes
Aug 7, 2023
askalt
force-pushed
the
askalt/no-gh-initial-logic
branch
4 times, most recently
from
78357c2 to
079cd8d
Compare
- `Converter[S,T]`: this in an interface for converting from S to T. Some basic converters were implemented: - converters from string to golang types - `IdentityConverter[S]`: a converter from S to any that doesn't change the input. - `FuncConverter[S,T]`: a converter based on the function. - `Mapper`: this is a struct, that maps tuples, using converter list. `Mapper` can be built using an array of converters, where each converter will be aplied to the corresponding index of the tuple. Also possible set a default converter, that will be aplied if the tuple length exceeds the length of the primary converters list. - `tt`: these are auxiliary functions used to build a converters list for the `Mapper`. - `TTConvFactory` is an abstract facture that can build a converter from type T to each tarantool type. To customize the behavior for specific types, one can inherit from the existing factory and override the necessary methods. - `StringToTTConvFactory` is the `TTConvFactory` implementation for strings to tt conversion. - `MakeTypeTTConverters[Type]` creates list of the converters from `Type` to tt types by the factory and space format. Closes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converter[S,T]: this in an interface for converting from S to T.Some basic converters were implemented:
converters from string to golang types
IdentityConverter[S]: a converter from S to any that doesn't change the input.FuncConverter[S,T]: a converter based on the function.Mapper: this is a struct, that maps tuples, using converter list.Mappercan be built using an array of converters, where each converterwill be aplied to the corresponding index of the tuple.
Also possible set a default converter, that will be aplied if the tuple length
exceeds the length of the primary converters list.
tt: these are auxiliary functionsused to build a converters list for the
Mapper.TTConvFactoryis an abstract facture that can builda converter from type T to each tarantool type.
To customize the behavior for specific types, one can inherit from the
existing factory and override the necessary methods.
StringToTTConvFactoryis theTTConvFactoryimplementation for strings to tt conversion.
MakeTypeTTConverters[Type]creates list ofthe converters from
Typeto tt types by the factory and space format.Closes #1