go-tupleconv: change the datetime conversion logic, improve tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalt
force-pushed
the
askalt/no-gh-save-timezone
branch
2 times, most recently
from
ed5cf37
to
91bce95
Compare
askalt
changed the title
askalt
force-pushed
the
askalt/no-gh-save-timezone
branch
from
91bce95
to
10469de
Compare
psergee
approved these changes
Aug 11, 2023
|
Pls, update changelog about changed date-time format and TZ support. |
converter.go
Outdated
| ttTimeLayout = "2006-01-02T15:04:05.999999-0700" | ||
| dateTimeLayout = "2006-01-02 15:04:05" | ||
| dateOnlyLayout = "2006-01-02" | ||
| dateLayout = "2006-01-02" |
There was a problem hiding this comment.
?
Suggested change
| dateLayout = "2006-01-02" | |
| dateLayout = time.DateOnly |
There was a problem hiding this comment.
Reworked, now only two required formats are supported by default:
- with numeric tz offset:
2006-01-02T15:04:05.999999999-0700 - with tz name:
2006-01-02T15:04:05.999999999 Europe/Moscow
askalt
force-pushed
the
askalt/no-gh-save-timezone
branch
from
10469de
to
ffb27fe
Compare
- Supported time layouts have been modified to be more strict. - Added the ability to specify time zone name in datetime.
askalt
force-pushed
the
askalt/no-gh-save-timezone
branch
from
ffb27fe
to
bf21e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datetimeconversion logic changes:Other:
MakeStringToTTConvFactory.