Can't build http rpm package using packpack #165
Comments
|
Lines 32 to 37 in c3d0883 Globbing here looks unusual. I would try %files
%{_libdir}/tarantool
%{_datarootdir}/tarantool
<...> |
Unfortunately, the same issue with this configuration |
|
Disregard, I realized that my suggestion is wrong. I should be like %files
%{_libdir}/tarantool/blabla
%{_datarootdir}/tarantool/foo.lua
%{_datarootdir}/tarantool/foo
<...>But maybe globbing is okay too. The problem is something else. |
|
How about using
|
I tried this config on different versions of OSes, it does not help, probably the root issue is somewhere else. |
|
I applied the changed suggested by https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds (taking compatibility with older systems into account): diff --git a/rpm/tarantool-http.spec b/rpm/tarantool-http.spec
index ee00cb5..d4d99ef 100644
--- a/rpm/tarantool-http.spec
+++ b/rpm/tarantool-http.spec
@@ -20,14 +20,19 @@ This package provides a HTTP server for Tarantool.
%setup -q -n %{name}-%{version}
%build
-%cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo
-make %{?_smp_mflags}
-
-%check
-make %{?_smp_mflags} luatest
+%cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo
+%if 0%{?fedora} >= 33 || 0%{?rhel} >= 8
+ %cmake_build
+%else
+ %make_build
+%endif
%install
-%make_install
+%if 0%{?fedora} >= 33 || 0%{?rhel} >= 8
+ %cmake_install
+%else
+ %make_install
+%endif
%files
%{_libdir}/tarantool/*/(I removed the luacheck call, because we have no packages for it.) The packages are successfully built for CentOS 7 and Fedora 36. Regarding versions: if you performed the steps from CI, you need extra care to deep clone and tags deannotation. See my comment here: https://github.com/tarantool/http/pull/164/files#r917260118. |
Starting with fedora 33, the cmake build strategy has been changed to "out-of-source builds" by default (see [1]). Let's add support for the new behavior. [1] https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Closes #165
Starting with fedora 33, the cmake build strategy has been changed to "out-of-source builds" by default (see [1]). Let's add support for the new behavior. Added `prebuild.sh` script with installation of Tarantool repo. [1] https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Closes #165
Starting with fedora 33, the cmake build strategy has been changed to "out-of-source builds" by default (see [1]). Let's add support for the new behavior. Added `prebuild.sh` script with installation of Tarantool repo. `Packpack` performs building rpm packages in a clean docker container. The container must contain `luatest` to perform testing during the build as it was set by `-DCMAKE_BUILD_TYPE=RelWithDebInfo` cmake var. This cmake var was removed in this commit as well as `%check` phase. It's quite challenging to set up `luacheck` while the package is building and a bit useless because the module is tested in another job. [1] https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Closes #165
Sorry for the silly questions, It's the first package I build using packpack.
When I build rpm package using
packpackI get an error:Then I try to modify tarantool-http.spec:
to
Okay, I guess it's not a proper way to use cmake in spec, but it starts to build.
The second issue after modifying the spec is that packpack can't find rpm:
The third issue is the version of the package. It's 0.0.1 even though I build it using a tag commit.
Please help!
The text was updated successfully, but these errors were encountered: