Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockspec: use git+https:// for git repository URL #148

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

Totktonada
Copy link
Member

GitHub is going to disable unencrypted Git protocol, so git:// URLs
will stop working soon (see 1).

Part of tarantool/tarantool#6587

GitHub is going to disable unencrypted Git protocol, so `git://` URLs
will stop working soon (see [1]).

[1]: https://github.blog/2021-09-01-improving-git-protocol-security-github/

Part of tarantool/tarantool#6587
@Totktonada
Copy link
Member Author

The same for http-v2-legacy: #149.

@ligurio
Copy link
Member

ligurio commented Nov 3, 2021

Minor: it makes sense to update a protocol in CHANGELOG too:

CHANGELOG.md:The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
CHANGELOG.md:and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

@Totktonada
Copy link
Member Author

(Sorry for delay, I misread your response first time.)

I would not transform this PR into 'use HTTPS everywhere' one. Here we resolve the problem with github.com access. It is not a code health change, it is the fix of infrastructure problem.

BTW, there are http:// links in README.md as well.

@ligurio ligurio merged commit 44d4685 into master Nov 9, 2021
@ligurio ligurio deleted the Totktonada/rockspec-use-git-plus-https branch November 9, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants