Skip to content

Commit

Permalink
Fix embedded bytecode loader.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Pall committed Jan 13, 2020
1 parent 45a7e50 commit 8203399
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/lj_bcread.c
Expand Up @@ -80,6 +80,7 @@ static LJ_NOINLINE void bcread_fill(LexState *ls, MSize len, int need)
ls->current = -1; /* Only bad if we get called again. */
break;
}
if (size >= LJ_MAX_MEM - ls->sb.n) lj_err_mem(ls->L);
if (ls->sb.n) { /* Append to buffer. */
MSize n = ls->sb.n + (MSize)size;
bcread_resize(ls, n < len ? len : n);
Expand Down Expand Up @@ -467,7 +468,7 @@ GCproto *lj_bcread(LexState *ls)
setprotoV(L, L->top, pt);
incr_top(L);
}
if ((int32_t)ls->n > 0 || L->top-1 != bcread_oldtop(L, ls))
if ((ls->n && !ls->endmark) || L->top-1 != bcread_oldtop(L, ls))
bcread_error(ls, LJ_ERR_BCBAD);
/* Pop off last prototype. */
L->top--;
Expand Down
5 changes: 5 additions & 0 deletions src/lj_lex.c
Expand Up @@ -49,6 +49,10 @@ static int fillbuf(LexState *ls)
size_t sz;
const char *buf = ls->rfunc(ls->L, ls->rdata, &sz);
if (buf == NULL || sz == 0) return END_OF_STREAM;
if (sz >= LJ_MAX_MEM) {
if (sz != ~(size_t)0) lj_err_mem(ls->L);
ls->endmark = 1;
}
ls->n = (MSize)sz - 1;
ls->p = buf;
return char2int(*(ls->p++));
Expand Down Expand Up @@ -382,6 +386,7 @@ int lj_lex_setup(lua_State *L, LexState *ls)
ls->lookahead = TK_eof; /* No look-ahead token. */
ls->linenumber = 1;
ls->lastline = 1;
ls->endmark = 0;
lj_str_resizebuf(ls->L, &ls->sb, LJ_MIN_SBUF);
next(ls); /* Read-ahead first char. */
if (ls->current == 0xef && ls->n >= 2 && char2int(ls->p[0]) == 0xbb &&
Expand Down
1 change: 1 addition & 0 deletions src/lj_lex.h
Expand Up @@ -72,6 +72,7 @@ typedef struct LexState {
BCInsLine *bcstack; /* Stack for bytecode instructions/line numbers. */
MSize sizebcstack; /* Size of bytecode stack. */
uint32_t level; /* Syntactical nesting level. */
int endmark; /* Trust bytecode end marker, even if not at EOF. */
} LexState;

LJ_FUNC int lj_lex_setup(lua_State *L, LexState *ls);
Expand Down

0 comments on commit 8203399

Please sign in to comment.