server: restore exec() sparse output support #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-350-nil-unpack
branch
from
ea2cc8d
to
3eb6f10
Compare
DifferentialOrange
changed the title
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-350-nil-unpack
branch
from
3eb6f10
to
962241b
Compare
After [1], returning values after nil (for example, classic
`return nil, err` scenario) is broken. This patch restores the behavior.
Since server doesn't always has access to `require('luatest.utils')`,
utility is provided through its dump.
Since `net.box` already handles `nil` args input with `box.NULL`,
everything is fine for exec arguments.
1. e6a2093
Closes #350
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-350-nil-unpack
branch
from
962241b
to
c8b69bf
Compare
That's fair, updated |
DifferentialOrange
changed the title
DifferentialOrange
added a commit
that referenced
this pull request
Jan 19, 2024
Simplify code from PR #351 based on @Totktonada advice. Follows #350
ochaplashkin
pushed a commit
that referenced
this pull request
Jan 19, 2024
Simplify code from PR #351 based on @Totktonada advice. Follows #350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After [1], returning values after nil (for example, classic
return nil, errscenario) is broken. This patch restores the behavior. Since server doesn't always has access torequire('luatest.utils'), utility is provided through its dump. Sincenet.boxalready handlesnilargs input withbox.NULL, everything is fine for exec arguments.I didn't forget about
Close #350