Update url in rockspec #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself is okay, but a future reader should know a reason. I suggest to include it into the commit message and the pull request description. |
yngvar-antonsson
force-pushed
the
update-rockspec
branch
from
f018c0c
to
792d46d
Compare
|
@Totktonada |
|
(I also recommend to consider our guidelines regarding commit messages: here rules 4 and 7 are violated. It is just my personal recommendation, I can't insist on it here.) |
Totktonada
approved these changes
Nov 2, 2021
Since github is improving git protocol security, old links to rockspecs will be unavailable. See https://github.blog/2021-09-01-improving-git-protocol-security-github/
yngvar-antonsson
force-pushed
the
update-rockspec
branch
from
792d46d
to
6ededdb
Compare
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GitHub is improving git protocol security, old links to rockspecs will be unavailable.
See https://github.blog/2021-09-01-improving-git-protocol-security-github/