Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add collectors from stats #4

Merged
merged 2 commits into from
Apr 23, 2019
Merged

add collectors from stats #4

merged 2 commits into from
Apr 23, 2019

Conversation

vpotseluyko
Copy link
Contributor

@vpotseluyko vpotseluyko commented Apr 17, 2019 •
edited

  • add collectors from stats
  • add api for enabling default metrics collection

@vpotseluyko vpotseluyko changed the title [wip] add network & operations collectors. Add external api for enabling … add collectors from stats Apr 18, 2019
ASverdlov
ASverdlov suggested changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@ASverdlov ASverdlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Thanks for the contribution!

There are some readability / naming questions that are genuinely think should be fixed to avoid confusion.

example/prometheus_export.lua Outdated Show resolved Hide resolved
metrics/collectors/utils.lua Outdated Show resolved Hide resolved
metrics/collectors/utils.lua Outdated Show resolved Hide resolved
metrics/collectors/system.lua Outdated Show resolved Hide resolved
metrics/collectors/init.lua Outdated Show resolved Hide resolved
metrics/collectors/init.lua Outdated Show resolved Hide resolved
metrics/init.lua Outdated Show resolved Hide resolved
ASverdlov
ASverdlov suggested changes Apr 22, 2019
View reviewed changes
metrics/default_metrics/tarantool/replicas.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/operations.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/network.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/memory.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/memory.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/info.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/fibers.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/fibers.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/utils.lua Outdated Show resolved Hide resolved
metrics/default_metrics/tarantool/init.lua Outdated Show resolved Hide resolved
@ASverdlov ASverdlov merged commit d0ba1a5 into master Apr 23, 2019
@ASverdlov
Copy link
Contributor

Merged. Thanks for contribution!

@printercu printercu deleted the add-default-collectors branch April 7, 2020 13:15
no1seman pushed a commit that referenced this pull request Feb 25, 2021
Fix promtool #4
7038470
no1seman pushed a commit that referenced this pull request Mar 11, 2021
add zone alias
677c7a9 
Fix promtool version

Set promtool version=2.25.0

Set promtool to latest

Fix promtool #4

Fix promtool #5

Fix promtool #6

Fix promtool #7

Fix promtool #8

Fix promtool #9

Fix promtool #11
no1seman pushed a commit that referenced this pull request Mar 16, 2021
add zone label
a46d280 
Fix promtool version

Set promtool version=2.25.0

Set promtool to latest

Fix promtool #4

Fix promtool #5

Fix promtool #6

Fix promtool #7

Fix promtool #8

Fix promtool #9

Fix promtool #11

Fix review comments

Fix check_cartridge_version() helper

CI: Add Cartridge 2.5.0 to test matrix
yngvar-antonsson pushed a commit that referenced this pull request Mar 17, 2021
@yngvar-antonsson
add zone label
7188d6b 
Fix promtool version

Set promtool version=2.25.0

Set promtool to latest

Fix promtool #4

Fix promtool #5

Fix promtool #6

Fix promtool #7

Fix promtool #8

Fix promtool #9

Fix promtool #11

Fix review comments

Fix check_cartridge_version() helper

CI: Add Cartridge 2.5.0 to test matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada left review comments

@filonenko-mikhail filonenko-mikhail filonenko-mikhail left review comments

@olegrok olegrok olegrok left review comments

@ASverdlov ASverdlov ASverdlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vpotseluyko @ASverdlov @Totktonada @filonenko-mikhail @olegrok