Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescape option not working correctly #120

Closed
dokshina opened this issue Apr 15, 2019 · 2 comments
Closed

Unescape option not working correctly #120

dokshina opened this issue Apr 15, 2019 · 2 comments
Assignees
@dedok
Labels
bug Something isn't working

Comments

@dokshina
Copy link

Because of incrementing variable s in this line

nginx_upstream_module/src/ngx_http_tnt_module.c

Line 1617 in 6c5696b

c = src->data[s++];

this check

nginx_upstream_module/src/ngx_http_tnt_module.c

Line 1619 in 6c5696b

if (c == '%' && (ngx_uint_t) (s + 2) < src->len) {

is false if the last string character is urlencoded.

So, the last urlencoded character will be ignored.
For example, for string %7B%7D will be returned {%7D.
dedok added a commit that referenced this issue Apr 15, 2019
@dedok
#120 fixed & add tests. Update (C) dates.
1a62080
@dedok
Copy link
Contributor

dedok commented Apr 15, 2019

Fixed in: 1a62080

@dedok dedok self-assigned this Apr 15, 2019
@dedok dedok added the bug Something isn't working label Apr 15, 2019
@dedok
Copy link
Contributor

dedok commented Apr 15, 2019

I closed this. Please feel free to reopen if error still exists.

@dedok dedok closed this as completed Apr 15, 2019
romanhabibov added a commit that referenced this issue Dec 15, 2020
@romanhabibov
Refix #120
312ecd5 
Fix unjustified changes in 26e5554 and redo 1a62080.
romanhabibov added a commit that referenced this issue Dec 15, 2020
@romanhabibov
Refix #120
e66791a 
Fix unjustified changes in 26e5554 and redo 1a62080.
@romanhabibov romanhabibov mentioned this issue Dec 17, 2020
Merged
romanhabibov added a commit that referenced this issue Jan 7, 2021
@romanhabibov
Fix #120 again
890c599 
Fix unjustified changes in 26e5554 which reopen #120 and redo the
changes of 1a62080.
romanhabibov added a commit that referenced this issue Jan 19, 2021
@romanhabibov
Fix bug with wrong urlencoding
84e6891 
Fix bug when the last urlencoded character was ignored. This patch
revert unjustified changes in 26e5554 which reopen #120 and redo
the changes of 1a62080.

Follows up #120
Totktonada pushed a commit that referenced this issue Mar 2, 2021
@romanhabibov @Totktonada
Fix bug with wrong urlencoding
ceb8a7a 
Fix bug when the last urlencoded character was ignored. This patch
revert unjustified changes in 26e5554 which reopen #120 and redo
the changes of 1a62080.

Follows up #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dedok dedok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dedok @dokshina