test: dont os.exit() in session disconnect trigger #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to make Tarantool shutdown graceful. Particularly for iproto graceful shutdown we wait while all connections are finished. On connection disconnect session disconnect triggers are invoked. If trigger hangs then graceful shutdown will hang too. And os.exit() do hang, it sleeps forever. So 110-disconnect-trigger-check.t test now hangs with iproto graceful shutdown patch. Making os.exit() from disconnect trigger does not seem as a product case. So let's just change the test not to use os.exit(). Required for full-ci pass of tarantool/tarantool#9457
LeonidVas
approved these changes
Dec 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to make Tarantool shutdown graceful. Particularly for iproto graceful shutdown we wait while all connections are finished. On connection disconnect session disconnect triggers are invoked. If trigger hangs then graceful shutdown will hang too. And
os.exit()do hang, it sleeps forever.So
110-disconnect-trigger-check.ttest now hangs with iproto graceful shutdown patch.Making
os.exit()from disconnect trigger does not seem as a product case. So let's just change the test not to useos.exit().Required for full-ci pass of tarantool/tarantool#9457