matras: introduce statistics #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the new matras_stat struct which is supposed to be passed to matras_create() for extent accounting. It's okay to pass the same struct to different matras allocators, in which case the statistics will be accumulated. Currently, matras_stat includes two counters: the total number of extents and the number of extents used by read views. We need this to implement read view statistics in Tarantool. Needed for tarantool/tarantool-ee#143
alyapunov
approved these changes
Mar 22, 2023
locker
added a commit
to locker/tarantool-small
that referenced
this pull request
Mar 23, 2023
In the small library all statistics structs are named FOO_stats, e.g. mempool_stats, small_stats. Let's rename matras_stat to matras_stats for consistency. Fixes commit c31879f ("matras: introduce statistics"). Follow-up tarantool#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new matras_stat struct which is supposed to be passed to matras_create() for extent accounting. It's okay to pass the same struct to different matras allocators, in which case the statistics will be accumulated. Currently, matras_stat includes two counters: the total number of extents and the number of extents used by read views. We need this to implement read view statistics in Tarantool.
Needed for https://github.com/tarantool/tarantool-ee/issues/143
In Tarantool repository the submodule will be updated by tarantool/tarantool#8482.