Add a simple DataSource implementation #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be rebased and merged after #172 |
Totktonada
reviewed
May 17, 2019
nicktorwald
force-pushed
the
nicktorwald/gh-175-datasource
branch
2 times, most recently
from
2a15aca
to
1bc0bf2
Compare
Totktonada
approved these changes
May 21, 2019
Implement the DataSource interface to be more compatible with JDBC spec. Add JDBC standard and Tarantool specific properties (getters/setters) to follow enterprise features (according to JavaBeans spec). Fix a JDBC URL scheme. Now correct scheme has the format like 'jdbc:tarantool://' where `tarantool` is JDBC sub-protocol. Old scheme version `tarantool://` was not JDBC-compatible. Closes: #175
nicktorwald
force-pushed
the
nicktorwald/gh-175-datasource
branch
from
1bc0bf2
to
8366d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the DataSource interface to be more compatible with JDBC spec.
Add JDBC standard and Tarantool specific properties (getters/setters) to
follow enterprise features (according to JavaBeans spec).
Closes: #175