Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resultSet.wasNull() #184

Merged
merged 2 commits into from
May 21, 2019
Merged

Support resultSet.wasNull() #184

merged 2 commits into from
May 21, 2019

Conversation

nicktorwald
Copy link

No description provided.

@nicktorwald
Copy link
Author

it depends on #163

@coveralls
Copy link

coveralls commented May 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 70.712% when pulling 3acf48c on nicktorwald/gh-179-resultset-was-null into 1cafd58 on master.

Totktonada
Totktonada reviewed May 17, 2019
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks okay in general. Please, see comments and questions below.

src/main/java/org/tarantool/jdbc/SQLResultSet.java Show resolved Hide resolved
src/test/java/org/tarantool/jdbc/AbstractJdbcIT.java Outdated Show resolved Hide resolved
src/test/java/org/tarantool/jdbc/JdbcResultSetIT.java Show resolved Hide resolved
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-179-resultset-was-null branch 2 times, most recently from 238e330 to 3acf48c Compare May 20, 2019 09:59
@nicktorwald nicktorwald changed the title nicktorwald/gh-179-resultset-was-null Support resultSet.wasNull() May 21, 2019
Totktonada
Totktonada approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nicktorwald
Change getUnicodeStream encoding from UTF-8 to UTF-16.
b9c8f36 
The JDBC standard requires two-bytes encoding to be returned from
getUnicodeStream.
@nicktorwald
Add a proper implementation for wasNull method
e0a1447 
Closes: #179
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-179-resultset-was-null branch from 3acf48c to e0a1447 Compare May 21, 2019 18:29
@nicktorwald nicktorwald merged commit 9f877a5 into master May 21, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-179-resultset-was-null branch May 21, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicktorwald @coveralls @Totktonada