Support JDBC escape syntax #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
from
843b7f1
to
d29b3d1
Compare
Totktonada
reviewed
Dec 3, 2019
There was a problem hiding this comment.
Thank you! I'm okay with the PR except several minor comments.
Use the following syntax for closing several issues from one commit:
Closes #xxx
Closes #yyy
Just Closes #xxx, #yyy does not work.
#80 is not closed here.
See other comments below.
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
2 times, most recently
from
2a1b6c1
to
a77d8e4
Compare
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
from
a77d8e4
to
dd73edd
Compare
Totktonada
reviewed
Dec 9, 2019
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
2 times, most recently
from
204508f
to
d1f72f2
Compare
nicktorwald
added a commit
that referenced
this pull request
Jan 15, 2020
The driver can connect to different Tarantool instances within a range of server versions. Sometimes, it's required to set a driver behaviour depending on those versions (i.e. in scope of #213 the driver needs to generate the functions for JDBC C4 LTRIM/RTRIM that are recognizable by a particular Tarantool version). This commit also includes implementation of two public DatabaseMetaData methods getDatabaseMajorVersion and getDatabaseMinorVersion. Affects: #213 Closes: #106
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
from
d1f72f2
to
d36814b
Compare
The driver can connect to different Tarantool instances within a range of server versions. Sometimes, it's required to set a driver behaviour depending on those versions (i.e. in scope of #213 the driver needs to generate the functions for JDBC C4 LTRIM/RTRIM that are recognizable by a particular Tarantool version). This commit also includes implementation of two public DatabaseMetaData methods getDatabaseMajorVersion and getDatabaseMinorVersion. Affects: #213 Closes: #106
Add a driver SQL pre-processing before sending it to the server. The driver supports sub-set of scalar functions defined by the spec (appendix C), outer joins, escape clause for SQL LIKE operator, and limit/offset clause. The processed result can be received using Connection.nativeSQL() method. Closes #79 Closes #76 Closes #81 Closes #83 Closes #84 Affects: #108
nicktorwald
force-pushed
the
nicktorwald/gh-79-escape-syntax
branch
from
d36814b
to
939a617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a driver SQL pre-processing before sending it to the server. The
driver supports sub-set of scalar functions defined by the spec
(appendix C), outer joins, escape clause for SQL LIKE operator, and
limit/offset clause. The processed result can be received using
Connection.nativeSQL() method.
Closes: #79
Closes: #76
Closes: #81
Closes: #83
Closes: #84
Affects: #108