Propagate client thumbstone when a client creation fails #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
force-pushed
the
nicktorwald/gh-30-socket-provider-error
branch
from
f4c2727
to
5235028
Compare
Totktonada
reviewed
Sep 10, 2019
There was a problem hiding this comment.
I'm okay with the changes.
Maybe it worth to add a test with the default socket provider (don't sure either catch real 'connection refuse' error or mock get() method). It also seems that it worth to test the cluster client with its default socket provider (this is the case on which a customer asks us how to check what is going wrong). After that we'll sure that a user will see a real reason in case of some connectivity problems (during a first connection as well as during a reconnection later).
nicktorwald
force-pushed
the
nicktorwald/gh-30-socket-provider-error
branch
from
5235028
to
868b377
Compare
Totktonada
approved these changes
Sep 13, 2019
nicktorwald
force-pushed
the
nicktorwald/gh-30-socket-provider-error
branch
2 times, most recently
from
6e93879
to
ab1c2f6
Compare
|
I'm ok. |
nicktorwald
force-pushed
the
nicktorwald/gh-30-socket-provider-error
branch
from
ab1c2f6
to
ed99a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate client thumbstone when a client creation fails
Closes: #30