Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue gathering acks for synchro transactions after restart #5856

Closed
sergepetrenko opened this issue Feb 26, 2021 · 2 comments
Closed

Continue gathering acks for synchro transactions after restart #5856

sergepetrenko opened this issue Feb 26, 2021 · 2 comments
Labels
feature A new functionality in design Requires design document

Comments

@sergepetrenko
Copy link
Collaborator

Now if a restart happens while some synchronous transactions are in flight, these transactions are left hanging until manual intervention with box.ctl.clear_synchro_queue or a new leader being elected, in case of raft.

Instead, master should gather acks for pending synchronous transactions after restarting, if it sees that there was no intervention into its limbo (noone else confirmed the transactions).

@sergepetrenko sergepetrenko added feature A new functionality in design Requires design document incoming labels Feb 26, 2021
@sergepetrenko
Copy link
Collaborator Author

Blocked by #5445

@kyukhin kyukhin added this to the wishlist milestone Jul 22, 2021
@kyukhin kyukhin removed the incoming label Jul 29, 2021
@sergepetrenko
Copy link
Collaborator Author

We shouldn't do this. Now the master's transaction limbo is frozen until it either receives a promote from remote instance or box.ctl.promote() is called manually on this instance. The recovered node should never confirm anything without consulting a quorum first.

@sergepetrenko sergepetrenko closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
@kyukhin kyukhin removed this from the wishlist milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality in design Requires design document
Projects
None yet
Development

No branches or pull requests

2 participants