Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swim: rename public API to 'membership' #5907

Open
Gerold103 opened this issue Mar 17, 2021 · 1 comment
Open

swim: rename public API to 'membership' #5907

Gerold103 opened this issue Mar 17, 2021 · 1 comment
Labels
refactoring Code refactoring
Milestone

Comments

@Gerold103
Copy link
Collaborator

The logic is the same as with 'raft' - nobody knows what 'swim'/'raft' is. It is simply confusing. Might be renamed to 'membership'. Or something equally general so as not to conflict with the existing 'membership' module which also implements swim.

The old module name could be kept for compatibility for some time. The rename should be trivial - only the string passed to require() must be changed. The API does not mention swim anywhere. Only the module name does.

The sooner we do it, the better and less intrusive it will be. Before people start using swim after its fixed (#5864, #5906).

@Gerold103 Gerold103 added refactoring Code refactoring incoming labels Mar 17, 2021
@kostja
Copy link
Contributor

kostja commented Mar 18, 2021

Such a great idea. And I also admire the false equivalence used to justify it.

@kyukhin kyukhin added the tmp label Jul 14, 2021
@kyukhin kyukhin added this to the wishlist milestone Jul 29, 2021
@TarantoolBot TarantoolBot removed the teamS label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

No branches or pull requests

4 participants