Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using is_async + on_push for net.box calls #6233

Open
rosik opened this issue Jul 20, 2021 · 1 comment
Open

Allow using is_async + on_push for net.box calls #6233

rosik opened this issue Jul 20, 2021 · 1 comment
Labels
feature A new functionality in design Requires design document

Comments

@rosik
Copy link
Contributor

rosik commented Jul 20, 2021

Is your feature request related to a problem? Please describe.

tarantool> conn:call('sub', nil, {is_async = true, on_push = print})
---
- error: 'builtin/box/net_box.lua:1062: To handle pushes in an async request use future:pairs()'
...

Net.box connections restrict using on_push triggers for async calls. I'm convinced this restriction is unreasonable.
The on_push trigger is anyway used implicitly, and equals table.insert:

tarantool> future = c:call('sub', nil, {is_async = true})
---
...

tarantool> future.on_push == table.insert
---
- true
...

Describe the solution you'd like

Let's make this use case allowed.

@rosik rosik added feature A new functionality incoming labels Jul 20, 2021
@Mons Mons added the in design Requires design document label Jul 23, 2021
@kyukhin kyukhin added teamP and removed incoming labels Jul 23, 2021
@Mons
Copy link
Contributor

Mons commented Jul 23, 2021

This feature requires the deep design of async interactions with net.box and other async approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality in design Requires design document
Projects
None yet
Development

No branches or pull requests

4 participants