Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew mvcc monitoring metrics #8149

Open
alyapunov opened this issue Jan 12, 2023 · 0 comments
Open

Renew mvcc monitoring metrics #8149

alyapunov opened this issue Jan 12, 2023 · 0 comments
Labels
blocked Not ready to be implemented feature A new functionality mvcc

Comments

@alyapunov
Copy link
Contributor

alyapunov commented Jan 12, 2023

In #8122 one of mvcc objects - memtx_tx_conflict - was removed as a class. However, it was not removed from mvcc memory monitoring by several reasons:

  1. It's a breaking change. At least metrics module relies on existence of this metric. Fix of that module and deprecation policy is needed.
  2. It is expected that some other objects can be removed in further refactoring and it is reasonable to postpone metrics renewal to that moment.
  3. It's a bit complicated and requires simultaneous update of (at least) metrics module.

We should return to this issues once mvcc refactoring is completed.

After #8654 the same story happened to tx_conflict_tracker.

@alyapunov alyapunov added feature A new functionality blocked Not ready to be implemented mvcc labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Not ready to be implemented feature A new functionality mvcc
Projects
None yet
Development

No branches or pull requests

1 participant