Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connpool: remove broken connections and ensure that the existing connection is for the intended instance #9910

Open
ImeevMA opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels
3.1 Target is 3.1 and all newer release/master branches bug Something isn't working connpool

Comments

@ImeevMA
Copy link
Collaborator

ImeevMA commented Apr 4, 2024

After #9892 is pushed to master we will have new problems:

  1. it's possible that the number of connections, including broken ones, will become more than 2^26 or Lua will run out of memory, so we need a mechanism to clean up broken or unnecessary connections.
  2. it is possible that the URI of the instance will change, but the connection will not be broken. In this case, we need to determine that the connection is not actually for the instance and create a new one.
@ImeevMA ImeevMA added the bug Something isn't working label Apr 4, 2024
@ImeevMA ImeevMA self-assigned this Apr 4, 2024
@Totktonada Totktonada added the 3.1 Target is 3.1 and all newer release/master branches label Apr 4, 2024
@R-omk
Copy link

R-omk commented Apr 4, 2024

#9563 related

@Totktonada Totktonada changed the title experimental: remove broken connections and ensure that the existing connection is for the intended instance connpool: remove broken connections and ensure that the existing connection is for the intended instance Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 Target is 3.1 and all newer release/master branches bug Something isn't working connpool
Projects
None yet
Development

No branches or pull requests

3 participants