Skip to content

Commit

Permalink
Fix non-supported character in log file name
Browse files Browse the repository at this point in the history
Running jobs in tarantool-ci fails at the action/upload-artifact runtime
if there are broken tests. The reason for the problem is that the path
of the test artifacts file contains the `:` character when test has been
parametrized.

Its non-supported character in the upload action. The action doesn't
allow the following characters in artifact path: ",:,<,>,|,*,?. [1]

To fix the problem, the `:` character has been replaced with `.`.

[1] https://github.com/actions/toolkit/blob/master/packages/artifact/docs/additional-information.md#non-supported-characters

Fixes tarantool/tarantool-qa#90
  • Loading branch information
Islam Elkanov authored and ylobankov committed Aug 4, 2023
1 parent 31f0ced commit c8465a5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/app_server.py
Expand Up @@ -116,9 +116,9 @@ def __init__(self, _ini=None, test_suite=None):
def logfile(self):
# remove suite name using basename
test_name = os.path.basename(self.current_test.name)
# add :conf_name if any
# add .conf_name if any
if self.current_test.conf_name is not None:
test_name += ':' + self.current_test.conf_name
test_name += '.' + self.current_test.conf_name
# add '.tarantool.log'
file_name = test_name + '.tarantool.log'
# put into vardir
Expand Down

0 comments on commit c8465a5

Please sign in to comment.