Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket.tcp_connect() in test_run:cmd() fails sporadically #193

Closed
PersDep opened this issue Nov 23, 2019 · 1 comment
Closed

socket.tcp_connect() in test_run:cmd() fails sporadically #193

PersDep opened this issue Nov 23, 2019 · 1 comment
Assignees
@PersDep

Comments

@PersDep
Copy link
Contributor

PersDep commented Nov 23, 2019

For some tests, for example, replication/box_set_replication_stress,
socket.tcp_connect() in test_run:cmd() might sometimes fail when
running under high load.

[015] Test failed! Result content mismatch:
[015] --- replication/box_set_replication_stress.result	Sat Nov 23 14:20:14 2019
[015] +++ replication/box_set_replication_stress.reject	Sat Nov 23 17:34:58 2019
[015] @@ -29,10 +29,13 @@
[015]   | ...
[015]  test_run:cmd("switch default")
[015]   | ---
[015] - | - true
[015] + | - error: '.../kosarev/tarantool/test/var/015_replication/test_run.lua:15: attempt
[015] + |     to index local ''sock'' (a nil value)'
[015]   | ...
PersDep added a commit that referenced this issue Nov 23, 2019
@PersDep
Stabilize tcp_connect in test_run:cmd()
b9dafc8 
For some tests, for example, replication/box_set_replication_stress,
socket.tcp_connect() in test_run:cmd() might sometimes fail when
running under high load. Now it is fixed.

Closes #193
PersDep added a commit to tarantool/tarantool that referenced this issue Nov 23, 2019
@PersDep
test: update test-run
e67404f 
Stabilize tcp_connect in test_run:cmd() (tarantool/test-run#193)
PersDep added a commit that referenced this issue Nov 26, 2019
@PersDep
Stabilize tcp_connect in test_run:cmd()
c707b3e 
For some tests, for example, replication/box_set_replication_stress,
socket.tcp_connect() in test_run:cmd() might sometimes fail with
"Too many open files" error when running under high load.
Now it is fixed.

Closes #193
PersDep added a commit that referenced this issue Nov 26, 2019
@PersDep
Stabilize tcp_connect in test_run:cmd()
1526a0f 
For some tests, for example, replication/box_set_replication_stress,
socket.tcp_connect() in test_run:cmd() might sometimes fail with
"Too many open files" error when running under high load. In case of
box_set_replication_stress test it happens because of a huge number of
file descriptors being opened during many box_set_replication calls.
Under high load it takes time for them to be closed. Now we are trying
to perform socket.tcp_connect() under test_run:wait_cond() clause until
we succeed or time is gone.

Closes #193
kyukhin pushed a commit to tarantool/tarantool that referenced this issue Dec 2, 2019
@PersDep @kyukhin
test: update test-run
a0b196d 
Stabilize tcp_connect in test_run:cmd() (tarantool/test-run#193)
kyukhin pushed a commit to tarantool/tarantool that referenced this issue Dec 2, 2019
@PersDep @kyukhin
test: update test-run
c3b0b79 
Stabilize tcp_connect in test_run:cmd() (tarantool/test-run#193)

(cherry picked from commit a0b196d)
kyukhin pushed a commit to tarantool/tarantool that referenced this issue Dec 2, 2019
@PersDep @kyukhin
test: update test-run
764544d 
Stabilize tcp_connect in test_run:cmd() (tarantool/test-run#193)

(cherry picked from commit a0b196d)
@PersDep PersDep self-assigned this Dec 2, 2019
@Totktonada
Copy link
Member

Discussion threads around the patches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PersDep PersDep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Totktonada @PersDep