Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reporting of luatest tests in case of failures #319

Closed
Tracked by #215
NickVolynkin opened this issue Feb 7, 2022 · 0 comments · Fixed by #320
Closed
Tracked by #215

Improve reporting of luatest tests in case of failures #319

NickVolynkin opened this issue Feb 7, 2022 · 0 comments · Fixed by #320
Assignees
Labels
bug Something isn't working

Comments

@NickVolynkin
Copy link
Contributor

NickVolynkin commented Feb 7, 2022

We need to write the reject file contents of failed luatest tests to the console output like it is done for TAP tests.
This is needed because it contains full information about failed tests.

ylobankov added a commit that referenced this issue Feb 8, 2022
This patch adds writing the rejected result file contents of failed
luatest tests to the console output. It is needed because such contents
contain full information about failed tests.

Before:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    Duration of failed tests (seconds):
    *   0.57 vinyl-luatest/update_optimize_test.lua
    *   0.75 vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua

    Top 10 longest tests (seconds):
    *   0.75 vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua
    *   0.57 vinyl-luatest/update_optimize_test.lua
    ---------------------------------------------------------------------------------
    Statistics:
    * fail: 2
    Failed tasks:
    - [vinyl-luatest/update_optimize_test.lua, null]
    # results file checksum: 93b316624a9a8c0237b3a9070825b805
    # logfile:        /private/tmp/tnt/log/001_vinyl-luatest.log
    # reproduce file: /private/tmp/tnt/reproduce/001_vinyl-luatest.list.yaml
    ---
    - [vinyl-luatest/update_optimize_test.lua, null]
    ...
    - [vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua,
      null]
    # results file checksum: 29e0210f3a1696ebb534224d662f6b3c
    # logfile:        /private/tmp/tnt/log/002_vinyl-luatest.log
    # reproduce file: /private/tmp/tnt/reproduce/002_vinyl-luatest.list.yaml
    ---
    - [vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua,
      null]

Now:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] Rejected result:
    [001]     TAP version 13
    [001]     1..6
    [001]     # Started on Tue Feb  8 19:56:23 2022
    [001]     # Starting group: vinyl-luatest.update_optimize
    [001]     not ok 1	vinyl-luatest.update_optimize.test_optimize_one_index
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:133: expected: {{2, 3, 4, 5, 6, 20}, {3, 4, 5, 6, 7}, {4, 5, 6, 7, 8}, {1, 2, 20, 4, 10, 1}}
    [001]     #   actual: {[2, 3, 4, 5, 6, 20], [3, 4, 5, 6, 7], [4, 5, 6, 7, 8], [1, 2, 20, 4, 10]}
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:36: in function 'vinyl-luatest.update_optimize.test_optimize_one_index'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     ok     2	vinyl-luatest.update_optimize.test_optimize_two_indexes
    [001]     not ok 3	vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:338: expected: {1, 2, 3, 4, 5, 5}
    [001]     #   actual: [1, 2, 3, 4, 5]
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:306: in function 'vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     not ok 4	vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:436: expected: {{10, 100, 1000, 10000, 100000, 1}, {20, 200, 2000, 20000, 200000, 2, 5}}
    [001]     #   actual: {[10, 100, 1000, 10000, 100000, 1], [20, 200, 2000, 20000, 200000, 2]}
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:394: in function 'vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     ok     5	vinyl-luatest.update_optimize.test_key_uniqueness_not_checked_if_indexed_fields_not_updated
    [001]     ok     6	vinyl-luatest.update_optimize.test_no_phantom_tuples_in_secondary_index
    [001]     # Ran 6 tests in 0.483 seconds, 3 succeeded, 3 failed
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] Rejected result:
    [002]     TAP version 13
    [002]     1..1
    [002]     # Started on Tue Feb  8 19:56:23 2022
    [002]     # Starting group: gh-6568-replica-initial-join-removal-of-compacted-run-files
    [002]     not ok 1	gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup
    [002]     #   ...ica_initial_join_removal_of_compacted_run_files_test.lua:72: the total actual size of run files directories of replica must not differ from box.stat.vinyl().disk.data by more than 100.0%
    [002]     #   Assertion failed: 3.7886345053148 <= 1
    [002]     #   stack traceback:
    [002]     #   	...ica_initial_join_removal_of_compacted_run_files_test.lua:72: in function 'gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup'
    [002]     #   	...
    [002]     #   	[C]: in function 'xpcall'
    [002]     # Ran 1 tests in 0.637 seconds, 0 succeeded, 1 failed
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    Duration of failed tests (seconds):
    *   0.56 vinyl-luatest/update_optimize_test.lua
    *   0.73 vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua

    Top 10 longest tests (seconds):
    *   0.73 vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua
    *   0.56 vinyl-luatest/update_optimize_test.lua
    ---------------------------------------------------------------------------------
    Statistics:
    * fail: 2
    Failed tasks:
    - [vinyl-luatest/update_optimize_test.lua, null]
    # results file checksum: 0c46705202140f21acbf35f170b116f6
    # logfile:        /private/tmp/tnt/log/001_vinyl-luatest.log
    # reproduce file: /private/tmp/tnt/reproduce/001_vinyl-luatest.list.yaml
    ---
    - [vinyl-luatest/update_optimize_test.lua, null]
    ...
    - [vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua,
      null]
    # results file checksum: b474cb38a9cc1680582bf38604708c2b
    # logfile:        /private/tmp/tnt/log/002_vinyl-luatest.log
    # reproduce file: /private/tmp/tnt/reproduce/002_vinyl-luatest.list.yaml
    ---
    - [vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua,
      null]

Closes #319
ylobankov added a commit that referenced this issue Feb 8, 2022
This patch adds writing the rejected result file contents of failed
luatest tests to the console output. It is needed because such contents
contain full information about failed tests.

Before:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Now:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] Rejected result:
    [001]     TAP version 13
    [001]     1..6
    [001]     # Started on Tue Feb  8 19:56:23 2022
    [001]     # Starting group: vinyl-luatest.update_optimize
    [001]     not ok 1	vinyl-luatest.update_optimize.test_optimize_one_index
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:133: expected: {{2, 3, 4, 5, 6, 20}, {3, 4, 5, 6, 7}, {4, 5, 6, 7, 8}, {1, 2, 20, 4, 10, 1}}
    [001]     #   actual: {[2, 3, 4, 5, 6, 20], [3, 4, 5, 6, 7], [4, 5, 6, 7, 8], [1, 2, 20, 4, 10]}
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:36: in function 'vinyl-luatest.update_optimize.test_optimize_one_index'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     ok     2	vinyl-luatest.update_optimize.test_optimize_two_indexes
    [001]     not ok 3	vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:338: expected: {1, 2, 3, 4, 5, 5}
    [001]     #   actual: [1, 2, 3, 4, 5]
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:306: in function 'vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     not ok 4	vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump
    [001]     #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:436: expected: {{10, 100, 1000, 10000, 100000, 1}, {20, 200, 2000, 20000, 200000, 2, 5}}
    [001]     #   actual: {[10, 100, 1000, 10000, 100000, 1], [20, 200, 2000, 20000, 200000, 2]}
    [001]     #   stack traceback:
    [001]     #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:394: in function 'vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump'
    [001]     #   	...
    [001]     #   	[C]: in function 'xpcall'
    [001]     ok     5	vinyl-luatest.update_optimize.test_key_uniqueness_not_checked_if_indexed_fields_not_updated
    [001]     ok     6	vinyl-luatest.update_optimize.test_no_phantom_tuples_in_secondary_index
    [001]     # Ran 6 tests in 0.483 seconds, 3 succeeded, 3 failed
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] Rejected result:
    [002]     TAP version 13
    [002]     1..1
    [002]     # Started on Tue Feb  8 19:56:23 2022
    [002]     # Starting group: gh-6568-replica-initial-join-removal-of-compacted-run-files
    [002]     not ok 1	gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup
    [002]     #   ...ica_initial_join_removal_of_compacted_run_files_test.lua:72: the total actual size of run files directories of replica must not differ from box.stat.vinyl().disk.data by more than 100.0%
    [002]     #   Assertion failed: 3.7886345053148 <= 1
    [002]     #   stack traceback:
    [002]     #   	...ica_initial_join_removal_of_compacted_run_files_test.lua:72: in function 'gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup'
    [002]     #   	...
    [002]     #   	[C]: in function 'xpcall'
    [002]     # Ran 1 tests in 0.637 seconds, 0 succeeded, 1 failed
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Closes #319
ylobankov added a commit that referenced this issue Feb 8, 2022
This patch adds writing the rejected result file contents of failed
luatest tests to the console output like it is done for TAP tests.
This is needed because it contains full information about failed tests.

Before:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Now:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/gh_6568_replica_initial_join_rem>                 [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject:
    [001] TAP version 13
    [001] 1..1
    [001] # Started on Wed Feb  9 00:25:23 2022
    [001] # Starting group: gh-6568-replica-initial-join-removal-of-compacted-run-files
    [001] not ok 1	gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup
    [001] #   ...ica_initial_join_removal_of_compacted_run_files_test.lua:72: the total actual size of run files directories of replica must not differ from box.stat.vinyl().disk.data by more than 100.0%
    [001] #   Assertion failed: 3.8947799385875 <= 1
    [001] #   stack traceback:
    [001] #   	...ica_initial_join_removal_of_compacted_run_files_test.lua:72: in function 'gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] # Ran 1 tests in 0.651 seconds, 0 succeeded, 1 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [001] vinyl-luatest/update_optimize_test.lua                          [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject:
    [001] TAP version 13
    [001] 1..6
    [001] # Started on Wed Feb  9 00:25:24 2022
    [001] # Starting group: vinyl-luatest.update_optimize
    [001] not ok 1	vinyl-luatest.update_optimize.test_optimize_one_index
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:133: expected: {{2, 3, 4, 5, 6, 20}, {3, 4, 5, 6, 7}, {4, 5, 6, 7, 8}, {1, 2, 20, 4, 10, 1}}
    [001] #   actual: {[2, 3, 4, 5, 6, 20], [3, 4, 5, 6, 7], [4, 5, 6, 7, 8], [1, 2, 20, 4, 10]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:36: in function 'vinyl-luatest.update_optimize.test_optimize_one_index'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     2	vinyl-luatest.update_optimize.test_optimize_two_indexes
    [001] not ok 3	vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:338: expected: {1, 2, 3, 4, 5, 5}
    [001] #   actual: [1, 2, 3, 4, 5]
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:306: in function 'vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] not ok 4	vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:436: expected: {{10, 100, 1000, 10000, 100000, 1}, {20, 200, 2000, 20000, 200000, 2, 5}}
    [001] #   actual: {[10, 100, 1000, 10000, 100000, 1], [20, 200, 2000, 20000, 200000, 2]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:394: in function 'vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     5	vinyl-luatest.update_optimize.test_key_uniqueness_not_checked_if_indexed_fields_not_updated
    [001] ok     6	vinyl-luatest.update_optimize.test_no_phantom_tuples_in_secondary_index
    [001] # Ran 6 tests in 0.388 seconds, 3 succeeded, 3 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Closes #319
@ylobankov ylobankov changed the title Improve test reports Improve reporting of luatest tests in case of failures Feb 8, 2022
@ylobankov ylobankov added the bug Something isn't working label Feb 8, 2022
ylobankov added a commit that referenced this issue Feb 8, 2022
This patch adds writing the `reject` file contents of failed luatest
tests to the console output like it is done for TAP tests. This is
needed because it contains full information about failed tests.

Before:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Now:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/gh_6568_replica_initial_join_rem>                 [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject:
    [001] TAP version 13
    [001] 1..1
    [001] # Started on Wed Feb  9 00:25:23 2022
    [001] # Starting group: gh-6568-replica-initial-join-removal-of-compacted-run-files
    [001] not ok 1	gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup
    [001] #   ...ica_initial_join_removal_of_compacted_run_files_test.lua:72: the total actual size of run files directories of replica must not differ from box.stat.vinyl().disk.data by more than 100.0%
    [001] #   Assertion failed: 3.8947799385875 <= 1
    [001] #   stack traceback:
    [001] #   	...ica_initial_join_removal_of_compacted_run_files_test.lua:72: in function 'gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] # Ran 1 tests in 0.651 seconds, 0 succeeded, 1 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [001] vinyl-luatest/update_optimize_test.lua                          [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject:
    [001] TAP version 13
    [001] 1..6
    [001] # Started on Wed Feb  9 00:25:24 2022
    [001] # Starting group: vinyl-luatest.update_optimize
    [001] not ok 1	vinyl-luatest.update_optimize.test_optimize_one_index
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:133: expected: {{2, 3, 4, 5, 6, 20}, {3, 4, 5, 6, 7}, {4, 5, 6, 7, 8}, {1, 2, 20, 4, 10, 1}}
    [001] #   actual: {[2, 3, 4, 5, 6, 20], [3, 4, 5, 6, 7], [4, 5, 6, 7, 8], [1, 2, 20, 4, 10]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:36: in function 'vinyl-luatest.update_optimize.test_optimize_one_index'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     2	vinyl-luatest.update_optimize.test_optimize_two_indexes
    [001] not ok 3	vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:338: expected: {1, 2, 3, 4, 5, 5}
    [001] #   actual: [1, 2, 3, 4, 5]
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:306: in function 'vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] not ok 4	vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:436: expected: {{10, 100, 1000, 10000, 100000, 1}, {20, 200, 2000, 20000, 200000, 2, 5}}
    [001] #   actual: {[10, 100, 1000, 10000, 100000, 1], [20, 200, 2000, 20000, 200000, 2]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:394: in function 'vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     5	vinyl-luatest.update_optimize.test_key_uniqueness_not_checked_if_indexed_fields_not_updated
    [001] ok     6	vinyl-luatest.update_optimize.test_no_phantom_tuples_in_secondary_index
    [001] # Ran 6 tests in 0.388 seconds, 3 succeeded, 3 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Closes #319
ylobankov added a commit that referenced this issue Feb 9, 2022
This patch adds writing the `reject` file contents of failed luatest
tests to the console output like it is done for TAP tests. This is
needed because it contains full information about failed tests.

Before:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/update_optimize_test.lua
    [001] not ok 1 vinyl-luatest.update_optimize.test_optimize_one_index #
    [001] not ok 3 vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64 #
    [001] not ok 4 vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump #
    [001] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject
    [001] [ fail ]
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [002] vinyl-luatest/gh_6568_replica_initial_join_rem>
    [002] not ok 1 gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup #
    [002] Rejected result file: /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject
    [002] [ fail ]
    [002] Worker "002_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Now:

    ======================================================================================
    WORKR TEST                                            PARAMS          RESULT
    ---------------------------------------------------------------------------------
    [001] vinyl-luatest/gh_6568_replica_initial_join_rem>                 [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files.reject:
    [001] TAP version 13
    [001] 1..1
    [001] # Started on Wed Feb  9 00:25:23 2022
    [001] # Starting group: gh-6568-replica-initial-join-removal-of-compacted-run-files
    [001] not ok 1	gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup
    [001] #   ...ica_initial_join_removal_of_compacted_run_files_test.lua:72: the total actual size of run files directories of replica must not differ from box.stat.vinyl().disk.data by more than 100.0%
    [001] #   Assertion failed: 3.8947799385875 <= 1
    [001] #   stack traceback:
    [001] #   	...ica_initial_join_removal_of_compacted_run_files_test.lua:72: in function 'gh-6568-replica-initial-join-removal-of-compacted-run-files.test_replication_compaction_cleanup'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] # Ran 1 tests in 0.651 seconds, 0 succeeded, 1 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    [001] vinyl-luatest/update_optimize_test.lua                          [ fail ]
    [001] Test failed! Output from reject file /tmp/tnt/rejects/vinyl-luatest/update_optimize.reject:
    [001] TAP version 13
    [001] 1..6
    [001] # Started on Wed Feb  9 00:25:24 2022
    [001] # Starting group: vinyl-luatest.update_optimize
    [001] not ok 1	vinyl-luatest.update_optimize.test_optimize_one_index
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:133: expected: {{2, 3, 4, 5, 6, 20}, {3, 4, 5, 6, 7}, {4, 5, 6, 7, 8}, {1, 2, 20, 4, 10, 1}}
    [001] #   actual: {[2, 3, 4, 5, 6, 20], [3, 4, 5, 6, 7], [4, 5, 6, 7, 8], [1, 2, 20, 4, 10]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:36: in function 'vinyl-luatest.update_optimize.test_optimize_one_index'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     2	vinyl-luatest.update_optimize.test_optimize_two_indexes
    [001] not ok 3	vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:338: expected: {1, 2, 3, 4, 5, 5}
    [001] #   actual: [1, 2, 3, 4, 5]
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:306: in function 'vinyl-luatest.update_optimize.test_optimize_UPDATE_with_field_num_more_than_64'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] not ok 4	vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump
    [001] #   ...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:436: expected: {{10, 100, 1000, 10000, 100000, 1}, {20, 200, 2000, 20000, 200000, 2, 5}}
    [001] #   actual: {[10, 100, 1000, 10000, 100000, 1], [20, 200, 2000, 20000, 200000, 2]}
    [001] #   stack traceback:
    [001] #   	...ce/tarantool/test/vinyl-luatest/update_optimize_test.lua:394: in function 'vinyl-luatest.update_optimize.test_optimize_update_does_not_skip_entire_key_during_dump'
    [001] #   	...
    [001] #   	[C]: in function 'xpcall'
    [001] ok     5	vinyl-luatest.update_optimize.test_key_uniqueness_not_checked_if_indexed_fields_not_updated
    [001] ok     6	vinyl-luatest.update_optimize.test_no_phantom_tuples_in_secondary_index
    [001] # Ran 6 tests in 0.388 seconds, 3 succeeded, 3 failed
    [001] Worker "001_vinyl-luatest" got failed test; restarted the server
    ---------------------------------------------------------------------------------
    ...

Closes #319
ylobankov added a commit to tarantool/tarantool that referenced this issue Feb 14, 2022
- Improve reporting from failed luatest tests (tarantool/test-run#319)
- Update luatest to 0.5.7 (tarantool/test-run#322)
ylobankov added a commit to tarantool/tarantool that referenced this issue Feb 14, 2022
- Improve reporting from failed luatest tests (tarantool/test-run#319)
- Update luatest to 0.5.7 (tarantool/test-run#322)
ylobankov added a commit to tarantool/tarantool that referenced this issue Feb 14, 2022
- Improve reporting from failed luatest tests (tarantool/test-run#319)
- Update luatest to 0.5.7 (tarantool/test-run#322)

(cherry picked from commit e4f9d04)
ylobankov added a commit to tarantool/tarantool that referenced this issue Feb 14, 2022
- Improve reporting from failed luatest tests (tarantool/test-run#319)
- Update luatest to 0.5.7 (tarantool/test-run#322)

(cherry picked from commit e4f9d04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants